Skip to content

lib/agentlib: add funcs to get cmd output on TA as TE string#100

Open
okt-kosovnn wants to merge 1 commit into
oktetlabs:mainfrom
okt-kosovnn:user/okt-kosovnn/ST-2731
Open

lib/agentlib: add funcs to get cmd output on TA as TE string#100
okt-kosovnn wants to merge 1 commit into
oktetlabs:mainfrom
okt-kosovnn:user/okt-kosovnn/ST-2731

Conversation

@okt-kosovnn

Copy link
Copy Markdown
Contributor
../cns-sapi-ts/run.sh --cfg=... --ool=onload --ool=no_reuse_pco --tester-run=sockapi-ts/tcp/tcp_handle_fin

looks good with Xilinx-CNS/cns-sapi-ts#133 and commenting out the introduced function ta_read_cmd() in SAPI-TS

Author: Nikolai Kosovskii <Nikolai.Kosovskii@arknetworks.am>
Date:   Fri Dec 5 14:25:59 2025 +0400

    remove ta_read_cmd

diff --git a/talib_sockapi_ts/parse_orm_json.c b/talib_sockapi_ts/parse_orm_json.c
index 9fb0310..0572f3e 100644
--- a/talib_sockapi_ts/parse_orm_json.c
+++ b/talib_sockapi_ts/parse_orm_json.c
@@ -104,6 +104,7 @@ rpc_tcp_state ci_tcp_state_2_rpc_tcp_state(int state_i)
   return state_strs[state_i];
 }
 
+#if 0
 /* See the description in parse_orm_json.h */
 te_errno
 ta_read_cmd(const char *cmd, te_string *str)
@@ -156,6 +157,7 @@ cleanup:
     return rc;
 }
 
+#endif
 /**
  * Check if struct sockaddr address @p addr has provided IP address and port.
  * Port is checked only if @p check_port is @c TRUE.
diff --git a/talib_sockapi_ts/parse_orm_json.h b/talib_sockapi_ts/parse_orm_json.h
index 92795dc..46a8763 100644
--- a/talib_sockapi_ts/parse_orm_json.h
+++ b/talib_sockapi_ts/parse_orm_json.h
@@ -48,6 +48,7 @@ rpc_tcp_state ci_tcp_state_2_rpc_tcp_state(int state_i);
 #define orm_json_tcp_state_2_rpc_tcp_state(_i) \
     ci_tcp_state_2_rpc_tcp_state(CI_TCP_STATE_NUM(_i))
 
+#if 0
 /**
  * Get output of command on TA in te_string representation
  *
@@ -58,6 +59,7 @@ rpc_tcp_state ci_tcp_state_2_rpc_tcp_state(int state_i);
  */
 te_errno ta_read_cmd(const char *cmd, te_string *str);
 
+#endif
 /**
  * Get TCP state from an orm_json tool's output.

Comment thread lib/agentlib/agentlib.h Outdated
Comment thread lib/agentlib/agentlib.h Outdated
Comment thread lib/agentlib/agentlib.h Outdated
AMD-Jira-ID: ST-2731
Signed-off-by: Nikolai Kosovskii <nikolai.kosovskii@arknetworks.am>
Reviewed-by: Yurij Plotnikov <yurij.plotnikov@arknetworks.am>
@okt-kosovnn okt-kosovnn force-pushed the user/okt-kosovnn/ST-2731 branch from b842eb5 to 51e8b38 Compare January 16, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants