lib/tapi: add missing value handler for te_bool3#96
Open
okt-dmitriyb wants to merge 1 commit into
Open
Conversation
okt-dmitriyb
force-pushed
the
opt-bool
branch
from
50f3e7a to
d2f852e
Compare
ol-arteman
requested changes
Oct 19, 2025
ol-arteman
left a comment
ol-arteman
left a comment
Collaborator
There was a problem hiding this comment.
Please add a case for the macro to suites/selftest/ts/minimal/parameters.c
Collaborator
|
Also, the commit message is pretty misleading, and the description seems to somewhat contradict the subject. |
okt-dmitriyb
force-pushed
the
opt-bool
branch
from
d2f852e to
19d41ff
Compare
okt-dmitriyb
changed the title
okt-dmitriyb
force-pushed
the
opt-bool
branch
from
19d41ff to
4309075
Compare
Author
|
Fixed |
ol-arteman
requested changes
Oct 20, 2025
ol-arteman
left a comment
ol-arteman
left a comment
Collaborator
There was a problem hiding this comment.
We have a policy that disallows referencing TE symbol names in the commit subject line.
ol-arteman
requested changes
Oct 20, 2025
okt-dmitriyb
force-pushed
the
opt-bool
branch
from
4309075 to
08d4ae6
Compare
okt-dmitriyb
changed the title
ol-andrewr
approved these changes
Jan 16, 2026
We need a way to handle missing value '-' literal for te_bool3 the same way it works with other optional types. Signed-off-by: Dmitriy Bulavskiy <Dmitriy.Bulavskiy@arknetworks.am>
okt-dmitriyb
force-pushed
the
opt-bool
branch
from
08d4ae6 to
72f0319
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with testsuite and minimal selftest.
TS_BASE=${TE_BASE}/suites/selftest/ts ./run.sh --tester-run=ts/minimal --cfg=localhost --log-html=html