Repository navigation
feat: add 1996 Reality Finance tokenized assets on Arbitrum (42161) - #253
Conversation
abs3ntdev
left a comment
There was a problem hiding this comment.
checked all 1996 tokens onchain, names/symbols/decimals match. a few things to fix:
- rRVMD has the Royalty Pharma logo, rGEMI has VanEck, rFLHY has First Trust. these are wrong upstream too but should be corrected here.
- rLGHL is 600x600 and rSNEX is 900x900. max is 256x256.
- rFTGC is named Synergetics even though FTGC is the First Trust commodity fund. please clarify with Reality.
- YY Group is rYFOR onchain but rYYGH in the registry. please confirm the mapping.
validate/lint pass. issuer address verification was limited to 344 tokens before the API started rate limiting.
gettty
left a comment
There was a problem hiding this comment.
Thanks for the thorough review — all good catches. Addressed:
Fixed (committed & pushed):
rRVMD,rGEMI,rFLHY— replaced wrong logos with correct ones (Revolution Medicines, Gemini, Franklin Templeton respectively), all square 256×256 PNG.rLGHL(600×600) andrSNEX(900×900) — resized down to 256×256.
On the two data questions — both stem from Reality's own registry, not my processing:
rFTGCnamed "Synergetics": the on-chainname()returns "Synergetics (Reality Tokenized)" — this is Reality's on-chain name, not something I introduced. FTGC is indeed the First Trust Global Tactical Commodity Strategy Fund ticker, so the on-chain name looks like a Reality-side data error. I've kept the on-chain name (correct per our convention of mirroringname()), but flagging for Reality to confirm/correct.rYFORvsrYYGH: on-chainsymbol()returnsrYFORandname()returns "YY Group (Reality Tokenized)". Reality's market registry lists this same contract under tickerYYGH(with a blank company name). My info.json uses the on-chain values (rYFOR / YY Group), which is the authoritative mapping. The registry'sYYGHlabel appears to be the stale one.
Note on issuer verification: I pulled all 1996 addresses directly from Reality's market API and verified name/symbol/decimals for all 1996 on-chain (not just 344) via batched eth_call, with zero failures — so the address↔metadata mapping is fully verified, independent of the arbiscan label-page rate limit you hit.
Let me know if you'd prefer I override the on-chain rFTGC name to "First Trust Global Tactical Commodity Strategy Fund (Reality Tokenized)" in the meantime.
|
Follow-up after merge: I ran a full audit of the 1,996 Reality tokens for the same class of issue that came up in review (upstream name/symbol mismatches). Everything traces back to Reality's own on-chain data (I mirror Confirmed on-chain mismatches (verified via
Symbol vs. registry conflict:
Advisory (odd names, plausibly correct private/pre-IPO entities): rASST/Strive, rBLSH/Bullish, rBOT/RoboStrategy, rBULL/Webull, rCRCL/Circle, rFIG/Figma, rSPCX/SpaceX, rMDLN/Medline, rEQPT/EquipmentShare, rNAVN/Navan, and ~17 more — full list available on request. Structural integrity confirmed clean: all 1,996 tokens have complete fields, decimals=18, no duplicate symbols, no oversized logos in the Reality set. Separately (not this PR): 4 pre-existing oversized logos on |
Adds all 1996 Reality Finance (Reality) tokenized equities/ETFs/commodities on Arbitrum (chain 42161).
Scope:
Example tokens:
Validation:
yarn validateandyarn biome checkboth pass clean.