Conversation
- Update paradigmxyz/reth tag from v1.11.0 to v1.11.3 - Bump deps/optimism submodule to 681867a2ed9707a976da302c488440ed76851242 (op-reth v1.11.3 compatible) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Previously TreeConfig was constructed from scratch with only persistence_threshold and memory_block_buffer_target, silently ignoring all other engine flags including --engine.legacy-state-root. Replace with builder.config().engine.tree_config() which applies all engine CLI arguments. This fixes the runtime panic: "wait_cloned must not be called from a rayon worker thread" When --engine.legacy-state-root is passed, tree_config() sets legacy_state_root=true, which causes use_state_root_task() to return false, selecting StateRootStrategy::Parallel and bypassing ProofWorkerHandle entirely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* main: fix(claude): dup comments @review and unwarranted auth step trigger (#202) feat(intercept): add bridge intercept in flashblocks (#177) add github token to claude step (#201) restore id-token (#200) fix: resolve Node compile issue, use nightly formatting, pin Rust to 1.93, and fix Claude 401s (#198) feat: integrate legacy migrate tool into bin/tools crate (#196) refactor(node): clean up main.rs (#187) feat(ci): restrict to PR author as triggerman (#195)
The github-script REST client was silently swallowing API errors (e.g. auth/permission failures), leaving has_alerts=false and causing all downstream steps to be skipped with no visible reason. Switch to gh CLI with GH_TOKEN so failures exit loudly with a clear error message. Also simplifies the code by doing the JSON filtering and reshaping in a single jq expression.
The Dependabot REST API returns 404 for GITHUB_TOKEN even with security-events: read in many org configurations. Switch to cargo audit --json which uses the same RustSec advisory database that Dependabot uses for Rust, needs no API permissions, and provides richer data (installed version, exact patched ranges, CVSS vector). Also drop the now-unnecessary security-events: read and id-token: write permissions from the job.
* main: fix(ci): switch from dependabot API to cargo audit fix(ci): use gh CLI to fetch dependabot alerts feat(claude): let AI sort out security issues (#203)
This reverts commit 9ab89c3.
This reverts commit 6c6335f.
|
@claude check this pr |
|
Claude finished @Vui-Chee's task in 1m 30s —— View job PR Review: feat: upgrade op-reth with reth v1.11.3
SummaryThis PR upgrades all Changed files:
What's GoodConsistent dependency upgrade. All 43 Correct submodule pairing. The Important engine bug fix included ( // Before — silently ignores most engine flags
let engine_tree_config = TreeConfig::default()
.with_persistence_threshold(builder.config().engine.persistence_threshold)
.with_memory_block_buffer_target(...);
// After — propagates all engine CLI arguments correctly
let engine_tree_config = builder.config().engine.tree_config();This fixes a real runtime panic ( NotesAlloy version pins remain unchanged. PR title vs commit prefix mismatch. The PR title uses Minimal PR description. The PR body only links to the upstream op-reth v1.11.3 commits. It would be helpful to mention the Extra CI commits on branch. The branch includes several CI-related commits ( VerdictThe core upgrade is clean and correct. The |
1 participant
https://github.com/ethereum-optimism/optimism/commits/op-reth/v1.11.3/