Skip to content

Remove promotion at start of description #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olaven merged 1 commit into from
Sep 30, 2025
Merged

Remove promotion at start of description #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/rss.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,12 @@ Deno.test("generated rss contains promo with link to donations page", () => {
"First promotion should come before the second",
);
});

Deno.test("first promotion is removed", () => {
const series = testUtils.generateSeries();
const feed = rss.assembleFeed(series);
const indexOfFirstPromotion = feed.indexOf(
"NRSS er avhengig av din Vipps-støtte",
);
assertEquals(indexOfFirstPromotion, -1, "First promotion should be removed");
});
5 changes: 2 additions & 3 deletions lib/rss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,10 @@ function assembleFeed(series: Series): string {
}

function descriptionWithDonationPromotion(description: string): string {
const firstPromotion = `⬇️NRSS er avhengig av din Vipps-støtte⬇️`;
const secondPromotion =
const promotion =
`Takk for at du bruker NRSS 🙏🌟 Vurder å støtte utviklingen via Vipps med omtrent det samme som prisen på en kaffekopp. Se mer på https://nrss.deno.dev/`;

return `${firstPromotion}\n\n${description}\n\n${secondPromotion}`;
return `${description}\n\n${promotion}`;
}

function assembleEpisode(episode: Episode, seriesId: Series["id"]): Tag {
Expand Down