Generate docker image, and publish to github repository - #52
Conversation
|
Fixes #51 |
|
Thank you for your contribution! I'ts very satisfying to see some life on this project :) I'd like to trim this down a little. Having a traefik gateway/proxy, automated pushing etc. feels like out of scope. What I like, and feel is within scope:
How do you feel about leaving these, but keeping the infra/hosting-code outside of this repo? EDIT: as a disclaimer, I should mention that I skimmed the changes, as I'd like to land on the above questions before giving this a thourough review. Thanks again! :) |
|
I could easily remove the Traefik edits, it just shows how you can host it yourself, and does not force the user to use it. I can redo that part as a docker-compose-traefik-sample if we still want to show how it could be done? |
I'd prefer to remove the traefik edits as well as the action pushing images. However, feel free to have traefik/compose/image-pushing as a sample/template in a separate repositry. If you create that, I'd be more than happy to reference it from the README, as an example to the user on how they could self host :) |
|
You don't want the docker image to be published in your repo either? Of course, all up to you as the owner of the project. I have btw ran this locally on my stack since it was removed from deno without any issues. |
No, however, I am planning to move this to my forgejo instance and have an image hosted there :)
I think this is a good and welcome solution :) Thank you for your patience! |
With a lot of help from an unnamed friend (Github CoPilot), we put together this. I am now running this locally on my stack, behind Traefik. Confirmed working.
ghcr.io/filllip/nrss:v0.1.0-beta