Skip to content

fix duplicate blocks #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PgNetwork01 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix duplicate blocks #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c5a3fa
Update block_registry.go
PgNetwork01 Apr 21, 2026
47ae154
Update block_registry.go
PgNetwork01 Apr 21, 2026
17e5d1e
Update block_registry.go
PgNetwork01 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions server/world/block_registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,16 @@ func (br *BlockRegistryImpl) RegisterBlock(b Block) {
}
}

// RegisterBlockState registers a blockStates to the states slice. The function panics if the properties the
// blockState hold are invalid or if the blockState was already registered.
// RegisterBlockState registers a block state in the registry.
// Duplicate states are ignored so malformed custom block entries from a remote server
// do not crash the proxy during login.
func (br *BlockRegistryImpl) RegisterBlockState(s BlockState) {
if br.finalized {
panic("BlockRegistry.RegisterBlockState called on finalized BlockRegistry")
}
h := stateHash{name: s.Name, properties: hashProperties(s.Properties)}
if _, ok := br.stateRuntimeIDs[h]; ok {
panic(fmt.Sprintf("cannot register the same state twice (%+v)", s))
return
}
if _, ok := br.blockProperties[s.Name]; !ok {
br.blockProperties[s.Name] = s.Properties
Expand Down Expand Up @@ -229,7 +230,7 @@ func (br *BlockRegistryImpl) Finalize() {
br.airRID = rid
}
if _, ok := br.stateRuntimeIDs[h]; ok {
panic(fmt.Sprintf("cannot register the same state twice (%s %+v)", name, properties))
continue
}
br.stateRuntimeIDs[h] = rid

Expand Down
Loading