add classes that manage operations on link#3
Open
kuchmei wants to merge 1 commit into
Open
Conversation
| } | ||
| } | ||
| } | ||
| else throw new ValueNotFoundExcetpion("URL is not found in the map"); |
Contributor
There was a problem hiding this comment.
@kuchmei, always use {} even when only one statement
| throw new ValueNotFoundExcetpion("ID is not found in the map"); | ||
| } | ||
| else{ | ||
| urlMap.remove(uuid); |
Contributor
There was a problem hiding this comment.
you deleted the URL in line 56
| urlMap.clear(); | ||
| System.out.println("Map is clean" + urlMap.keySet()); | ||
|
|
||
| return urlMap; |
Contributor
There was a problem hiding this comment.
you need to return old map, before cleaning
| } | ||
|
|
||
| System.out.println("Link is: " + urlMap.get(uuid)); | ||
| return urlMap.get(uuid); |
Contributor
There was a problem hiding this comment.
maybe urlMap.get(uuid) change local variable
| else throw new ValueNotFoundExcetpion("URL is not found in the map"); | ||
|
|
||
|
|
||
| return null; |
Contributor
There was a problem hiding this comment.
you need return UUID
| System.out.println(e.getMessage()); | ||
| } | ||
| catch (Exception e){ | ||
| throw new Error(); |
There was a problem hiding this comment.
do not throw an error never
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.