Rectangle by @AlexU238#2
Open
AlexU238 wants to merge 1 commit into
Open
Conversation
malvitvik
reviewed
Jul 16, 2019
| @@ -0,0 +1,38 @@ | |||
| public class Rectangle { | |||
| private int hight; | |||
| private int width; | ||
|
|
||
| public Rectangle(){ | ||
|
|
There was a problem hiding this comment.
What is the purpose of empty constructor? What values are going to be used for height' and 'width' variables?
| } | ||
|
|
||
| public void findPerimeter(){ | ||
| System.out.println("Периметр прямоугольника == "+(2*(hight+width))); |
There was a problem hiding this comment.
Pls use space between math sign and variable
' " + (2 * (height + width)) ' is reading easier than without space.
| } | ||
|
|
||
|
|
||
| public int getHight() { |
There was a problem hiding this comment.
Why both setters and getters? It is easier to do a 'public' field.
oleksandr-kazimirov
approved these changes
Jul 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.