docs(rules): the coai feature gate — when to call it, what the verdicts mean - #55
oleksandrdubyna88 wants to merge 3 commits into
Conversation
…ts mean The review server gains a fourth stage, review_feature: one review of a whole plan of three or more epics, after its last epic and before the release. The rule lives here because the server gates every repository in the family (operator, 2026-09-26). It says when to call it, what to pass (the plan path as the identity, the first epic's base, every epic with its summary and branch or pull request, honest lessons), what each verdict asks of the caller, and the round cap: a second round only after a reviewer failure, a blocking finding or the person's request, never a third. It says plainly that nothing checks whether it was run. Batched with it, as the operator approved: - coai-consultant trigger 7: a cadence consultation counts only after close_consult records solved, not_solved or abandoned. - README: the promote-release dispatch takes a required reason input beside the sha; without it the dispatch answers 422. rule-bodies.json gained the new entry by hand and both hashes were recorded with --update naming the two ids. Observed: npm test 236 pass, 0 fail, 1 skipped; npm run check resolved; ownership-check OK over 34 rules; rule-bodies OK; plan-lifecycle clean; adapter-check OK. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@coderabbitai review |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: oleksandrdubyna88/dew_flow_conventions/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughОбновлены инструкции запуска ChangesИнструкции запуска выпуска
Завершение cadence-консультации
Проверка функции перед выпуском
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The documented release and review workflows have no identified issue requiring a change before merge. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 3 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The queued trigger-7 edit was approved together with a version bump: coai's CONSULTANT_VERSION moves 3 -> 4, so a pasted copy of v3 must see the text as new. The marker line is the only thing in this repository that pins the number; canonical-markers.test.mjs leaves the version free and no fixture carries it. rule-bodies.json recorded with --update common.coai-consultant only. Observed: npm test 236 pass, 0 fail, 1 skipped; npm run check resolved; ownership-check OK over 34 rules; rule-bodies OK; plan-lifecycle clean; adapter-check OK; branch-protection selftest OK. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…he failed are asked, call_human on the second failure Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|



What this adds
common/coai-feature-gate.md(common.coai-feature-gate) — the caller's rule for the review server's fourth stage,review_feature: one review of a whole plan of three or more epics, after its last epic and before the release. It lives here because the server gates every repository in the family (operator, 2026-09-26). It is short on purpose: the tool description carries the parameters and limits; the rule saysCOAI_FEATURE_MIN_EPICS, default 3), fully implemented, before the release; not per epic, since each epic's own code round stays;planPath(the review's identity, passed again asfeaturetoresolve/status/ask_human),baseRef= the commit the first epic branched from, every epic with its summary and branch or PR, honestlessons(an empty category says why, in at least 20 characters),callerModel;proceed;revise→ resolve every finding, fix and commit the accepted ones, and run a second round withagain: trueonly after a reviewer failure, ablockingfinding or the person's request — otherwise one round, and never more than two;call_humanstops the shipping, not the task (also the answer when every reviewer failed);skippednever blocks;consultbeforeresolve;It carries a
<!-- coai-feature v1 -->marker in the shape of the other four coai rules, so a consumer can generate from it later. It is not added tocanonical-markers.test.mjs, because no consumer build reads it yet.Two batched edits (approved by the operator to ride with the next conventions change)
common/coai-consultant.md, trigger 7: "a cadence consultation counts only when it has one" is replaced with "A cadence consultation counts only afterclose_consultrecordssolved,not_solvedorabandoned." The marker rises to<!-- coai-consultant v4 -->with it (coai's CONSULTANT_VERSION 3 → 4), so pasted copies see the text as new.reasoninput beside the sha (-f reason="…"); without it the dispatch answers 422.Records and checks
research/rule-bodies.json: the new entry added by hand, as a new rule must be;common.coai-feature-gateandcommon.coai-consultantrecorded withnode tools/rule-bodies.mjs --updatenaming exactly those two ids.research/module_tests.md: a short section on what checks the new rule and what deliberately does not.npm test236 pass / 0 fail / 1 skipped;npm run checkresolved;ownership-checkOK (34 rules, no undeclared references);rule-bodiesOK;plan-lifecycleclean;adapter-checkOK; branch-protection selftest OK.Do not promote to
releaseuntil coai shipsreview_feature(mcp ≥ 0.39.0); the promotion starts the six-consumer pin cascade.🤖 Generated with Claude Code
Summary by CodeRabbit