WIP: Fast Minimum Variance beamformer (postprocess.fast_minimum_variance) - #37
Draft
olemarius90 wants to merge 1 commit into
Draft
olemarius90 wants to merge 1 commit into
olemarius90 wants to merge 1 commit into
Conversation
…pper has residual mismatch Status: - Core MV algorithm (covariance, weights, application) verified pixel-by-pixel to produce IDENTICAL results to capon_minimum_variance_implementation - But when called through go(), output differs by factor ~1.85x - Issue is NOT in: K_samples, L_elements, data_cube values, R matrices, or normalization - Issue likely in: how input.data dimensions are indexed in the go() loop (possibly a subtle 3D vs 4D squeeze/reshape edge case) Files: - +postprocess/fast_minimum_variance.m: full implementation with debug prints - examples/advanced_beamforming/fast_minimum_variance_example.m: validation script Co-authored-by: Ole Marius Hoel Rindal <olemarius90@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Fast Minimum Variance Beamformer
Efficient reimplementation of
postprocess.capon_minimum_varianceas a drop-in replacement.Status: debugging go() wrapper mismatch
What works:
dimension,K_in_lambda,L_elements,regCoef,doForwardBackwardKnown issue:
go(), output differs from reference by a consistent factor ~1.85xh.input.dataor stores resultsFiles
+postprocess/fast_minimum_variance.m— implementationexamples/advanced_beamforming/fast_minimum_variance_example.m— validation script comparing against referenceNext steps