Fix TheGB dataset previews: use correct sound speed from UFF file - #39
Merged
Merged
Conversation
…ded 1460) The 1460 m/s was incorrectly taken from a speed-of-sound exercise. The UFF files store the correct acquisition sound speed. Regenerated previews for L7_CPWC/DW/STA/FI_TheGB. datasets-html.tar.gz re-uploaded to examples-v1. Co-authored-by: Ole Marius Hoel Rindal <olemarius90@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TheGB dataset preview sound speed
The preview images for L7_CPWC/DW/STA/FI_TheGB were beamformed with
sound_speed = 1460(hardcoded from a speed-of-sound exercise). This caused defocused point spread functions.Fix: Removed the
channel_data.sound_speed = 1460override — now uses the sound speed stored in the UFF file.Updated
datasets-html.tar.gzuploaded toexamples-v1release with corrected previews.