Fix gray dataset preview thumbnails (headless PNG export) - #43
Merged
Merged
Conversation
- export_dataset_previews_to_website uses tools.zenodo_dataset_files_base() - UFF_Verasonics_all: use sound speed from UFF file (remove 1460 override) Co-authored-by: Ole Marius Hoel Rindal <olemarius90@users.noreply.github.com>
- export_png_like_b_data_plot deletes uicontrol sliders added by b_data.plot (fixes headless 'Printing of uicontrols is not supported' failures) - read_beamformed_only_for_preview tries /b_data_das and related groups without erroring on missing /b_data Co-authored-by: Ole Marius Hoel Rindal <olemarius90@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After fixing TheGB sound speed, many dataset thumbnails on the website turned gray. The export run only succeeded for 33/51 datasets; failures wrote gray stub PNGs.
Root causes:
b_data.plotadds uicontrol sliders — headlessprint/exportgraphicsfails with "Printing of uicontrols is not supported"beamformed_simulated_data.uff, etc.) have no/b_datagroup — only/b_data_das, etc.Fix
export_png_like_b_data_plot.mbefore capturing the figureread_beamformed_only_for_previewwith safe path fallbackstools.zenodo_dataset_files_base())datasets-html.tar.gz(9.8 MB) toexamples-v1release onolemarius90/USTBAfter merge
Re-run Deploy Website to GitHub Pages on
unioslo/USTB(needsdeploy-pages@v5from master if not already merged upstream).