feat: implement merkle_check in Noir with comprehensive tests#6
Merged
olivmath merged 2 commits intoDec 6, 2025
Merged
Conversation
Add merkle proof verification functionality in Noir: - merkle_check function to verify proofs and compute root - Support for generic hash functions via HashFn type - Comprehensive tests for even, odd, and power-of-2 leaf counts - Uses Keccak256 for testing (matching Rust reference implementation) The function iterates through proof nodes and applies hashing based on node side (LEFT/RIGHT) to reconstruct the Merkle root from a leaf.
Rename the function to merkle_proof_check for consistency with existing documentation and examples. Add comprehensive documentation: - Rename function from merkle_check to merkle_proof_check - Update all tests to use new function name - Add new example showing low-level API usage - Update README to list new example This ensures consistency across the codebase and makes the function name match what's already documented in README and used in examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add merkle proof verification functionality in Noir:
The function iterates through proof nodes and applies hashing based on node side (LEFT/RIGHT) to reconstruct the Merkle root from a leaf.