THREADS-26/27: send include_urls and exclude_urls to the maps API - #18
Open
ZeeshanAdilButt wants to merge 1 commit into
Open
THREADS-26/27: send include_urls and exclude_urls to the maps API#18ZeeshanAdilButt wants to merge 1 commit into
ZeeshanAdilButt wants to merge 1 commit into
Conversation
Collaborator
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The create_map tool sent include_url_patterns / exclude_url_patterns to /v1/maps, but the REST API filters on include_urls / exclude_urls, so the glob filter was silently ignored.
Now the tool maps its inputs to the correct payload keys (include_urls / exclude_urls). The tool-facing input names are unchanged, so existing MCP users are unaffected, but the filter now actually applies. Verified live that include_urls narrows the result set. OLO-MAP-03 / OLO-MAP-04.