Repository navigation
fix(postgres): advance replication slot on idle keepalives - #88
Merged
olucasandrade merged 4 commits intoSep 25, 2026
Merged
olucasandrade merged 4 commits into
olucasandrade merged 4 commits into
Conversation
Persist and ack keepalive ServerWALEnd when no published-table work is in flight so unpublished WAL no longer pins confirmed_flush_lsn, while keeping the CHK-01 lastSavedLSN cap for in-flight commits. Introduced-by: fccab63
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying kaptanto with
|
| Latest commit: |
1125932
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f1180776.kaptanto.pages.dev |
| Branch Preview URL: | https://fix-postgres-keepalive-slot.kaptanto.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan
.claude/fix-plans/postgres-keepalive-slot-advance-20260924-212132.mdProblem
After the CHK-01 standby cap, keepalive
ServerWALEndupdatesclientXLogPosbut is never persisted, soconfirmed_flush_lsncannot advance past the last published-table transaction. Heavy writes on unpublished tables retain WAL indefinitely.Introduced by
fccab63
Implementation
txOpen(set on Begin, cleared on Commit / StreamCommit / StreamAbort).maybeAdvanceOnKeepalive: persist and ackclientXLogPosonly when ahead oflastSavedLSNandidleForSlotAdvance()(walBufempty,!streamedOpen,!txOpen). Otherwise keepackLSNcap atlastSavedLSN(fail closed, CHK-01).applyKeepalivecentralizes ServerWALEnd update + advance/reply decision for the fake-walsender tests.Validation
CGO_ENABLED=0 go test ./internal/source/postgres -count=1— passlastSavedLSN; published Commit still checkpoints; streamed open blocks advanceResidual risk
walBufafter mid-tx flush) blocks keepalive advance until Commit — unpublished WAL behind that tx still holds briefly.txOpen/streamedOpenclear would re-pin the slot (fail closed for CHK-01, not for WAL growth).