Repository navigation
fix(webhook): require literal host in url-template (WHK-04) - #89
Merged
olucasandrade merged 4 commits intoSep 25, 2026
Merged
Conversation
Prevent row-data-controlled hosts from steering sink credentials and payloads by validating a fixed authority at startup and refusing to dial or attach Authorization when the rendered host differs. Introduced-by: 3ed66d7
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying kaptanto with
|
| Latest commit: |
063ea02
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d2e3923c.kaptanto.pages.dev |
| Branch Preview URL: | https://fix-webhook-url-template-ssr.kaptanto.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan
.claude/fix-plans/webhook-url-template-ssrf-20260924-212132.mdProblem
url-templatevalues could place event/row fields in the URL authority. At render time onlyhttp/httpswas required, so a writer to a replicated table could steer delivery — including precomputedAuthorizationand the full event payload — to an attacker-controlled or cloud-metadata host.Introduced by
3ed66d7
Implementation
url-templatemay be data-driven only in path/query; host/userinfo must be a literal validated at startup (reject authority containing{{or{%).Authorization(also checked indoRequestas defense-in-depth).internal/output/webhook(nointernal/enrichimport; depguard unchanged).Validation
CGO_ENABLED=0 go test ./internal/output/webhook -count=1Pass. Coverage includes: startup rejects
{{host}}in authority; host mismatch does not dial / does not attach auth; literal host + path templates still deliver.Residual risk
WHK-02).