Repository navigation
fix(mongodb): page snapshot by _id keyset windows - #90
Merged
olucasandrade merged 4 commits intoSep 25, 2026
Merged
olucasandrade merged 4 commits into
olucasandrade merged 4 commits into
Conversation
Avoid materializing the full collection into memory during re-snapshot; process bounded windows and persist last `_id` for mid-crash resume. Introduced-by: bbd2b0d
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…-keyset-streaming
Deploying kaptanto with
|
| Latest commit: |
3fa217f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a0dcce87.kaptanto.pages.dev |
| Branch Preview URL: | https://fix-mongodb-snapshot-keyset.kaptanto.pages.dev |
…-keyset-streaming
…-keyset-streaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan
.claude/fix-plans/mongodb-snapshot-keyset-streaming-20260924-212132.mdProblem
MongoSnapshot.fetchDocsappended every document into[]bson.Rawbefore any row was processed. Package comments claimed keyset discipline, but there was no pagination — a large collection re-snapshot could OOM the process mid-recovery (InvalidResumeToken → outage).Introduced by
bbd2b0d
Implementation
fetchDocswith_idkeyset windows ($gt+Limit), default batch size 256 (matches Postgres backfill).ShouldEmit+ append) before fetching the next; peak buffering is one window.CheckpointStoreprogress keys{sourceID}:{coll}:snapshotpersist the last scanned_idafter each completed window; cleared onsnapshot_complete. Distinct from change-stream resume tokens; empty progress is never treated as a resume-token Save.SetProgressStore(ckStore)from the Mongo re-snapshot path ininternal/cmd/mongo.go.findFnstill returns[]bson.Rawper call; callers pass keyset filter + limit via opts.Validation
CGO_ENABLED=0 go test ./internal/source/mongodb -count=1(pass)_id.Residual risk
_idtypes across a collection can break$gtordering (same class of risk as any Mongo keyset scan).