Skip to content

fix(ci): build bench images with Go 1.26.9 - #98

Merged
olucasandrade merged 1 commit into
mainfrom
ci/bench-go-1.26.9
Oct 13, 2026
Merged

olucasandrade merged 1 commit into
mainfrom
ci/bench-go-1.26.9

Conversation

@olucasandrade

Copy link
Copy Markdown
Owner

Summary

  • Bench images were still built with Go 1.25.8, so go mod download failed on main after the module moved to Go 1.26.9.
  • Drop the grpc 1.84.x Dependabot ignore. v1.84.0 is outside the current GO-2026-6443 range, which govulncheck confirmed on chore(deps): bump google.golang.org/api from 0.298.0 to 0.300.0 in the go-dependencies group #97.
  • Ignore github.com/twmb/franz-go/pkg/kfake. Dependabot resolves that nested module as franz-go@v1.22.2, which does not contain the package, and that error fails the update job.

Test plan

  • Benchmark workflow on main gets past go mod download for the kaptanto images
  • Dependabot Go update job no longer fails on kfake

The benchmark Dockerfiles still used Go 1.25.8, so go mod download
failed after the root module moved to 1.26.9. Drop the stale grpc
1.84.x ignore now that v1.84.0 is outside the GO-2026-6443 range, and
ignore kfake so Dependabot stops failing the update job on it.
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d49943aa-2057-409c-8859-aff565bd4202
📥 Commits

Reviewing files that changed from the base of the PR and between 357331f and 5a72807.

📒 Files selected for processing: 3
  • .github/dependabot.yml
  • bench/Dockerfile.bench
  • bench/Dockerfile.bench-rust
 _______________________________________________________________________________________________________________
< Make quality a requirements issue. Involve your users in determining the project's real quality requirements. >
 ---------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@olucasandrade
olucasandrade merged commit 60ff9c5 into main Oct 13, 2026
14 of 15 checks passed
@olucasandrade
olucasandrade deleted the ci/bench-go-1.26.9 branch October 13, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant