Repository navigation
Dev - #3
Closed
thanhthien1305 wants to merge 7 commits into
Closed
Dev#3thanhthien1305 wants to merge 7 commits into
thanhthien1305 wants to merge 7 commits into
Conversation
Adds `vi` alongside `en` and `pt-BR`: UI strings, 33 cases, 45 cheatsheet
cards, concepts, and 23 builder challenges, plus the wiring to load them
(locale type, translation map, case/challenge loaders, header + mobile
menu toggle) and parity tests covering the new locale.
Swaps the font stack to Be Vietnam Pro / Montserrat / JetBrains Mono so
Vietnamese diacritics render correctly, and drops the scan-line overlay
that made stacked diacritics hard to read.
Terminology follows a single glossary rather than literal translation.
Notably `idempotency` was rendered as "lũy thừa" (exponentiation) in 20
places; it is now "tính idempotent". Same for failover ("chuyển vùng" =
roaming -> "chuyển đổi dự phòng"), node ("nút" = button -> "node"),
quorum ("túc số" -> "quorum"), and queue messages ("tin nhắn" = SMS ->
"thông điệp"). Genuine uses of those words — pressing a button, the
"nút thắt cổ chai" idiom, clipboard copies, real chat messages — are
kept as they were.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Commits the pnpm-lock.yaml and pnpm-workspace.yaml produced by the switch to pnpm, and allows esbuild to run its install script. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (80)
📝 WalkthroughWalkthroughVietnamese support is added across the interface, 33 training cases, 23 builder challenges, concepts, cheatsheet data, locale-aware loaders, validation scripts, and typography. Package configuration permits ChangesVietnamese localization
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant LocaleSelector
participant GameState
participant useCase
participant VietnameseData
LocaleSelector->>GameState: setLocale('vi')
GameState->>useCase: select Vietnamese loaders and indexes
useCase->>VietnameseData: load case, concept, and challenge data
VietnameseData-->>useCase: return localized content
useCase-->>LocaleSelector: render Vietnamese content
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues
Fixes #
Relates to #
Changes
Testing
Manual Testing
Checklist
npm run lint)npm run build)Checklist
Screenshots or Videos
Additional Notes
Summary by CodeRabbit
New Features
Style
Bug Fixes