Skip to content

List Home and its standard folders in the sidebar, not every folder in home - #108

Closed
amagdy46 wants to merge 2 commits into
omacom:mainfrom
amagdy46:sidebar-places-and-pins
Closed

amagdy46 wants to merge 2 commits into
omacom:mainfrom
amagdy46:sidebar-places-and-pins

Conversation

@amagdy46

Copy link
Copy Markdown

The sidebar lists every folder in home under Home. With a few dozen folders, the ones used daily are buried and Pinned sits below them all (#76). Bookmarks seeded from Nautilus for top-level home folders are also skipped as "already under Home", so pinning can't fix it.

What changes

  • Places is Home and its standard folders: Home, then Desktop, Documents, Downloads, Music, Pictures and Videos where they exist (following user-dirs), then Recents and Trash. The Views heading goes; Recents and Trash end the section, as in Nautilus.
  • Any other folder in home can be pinned, and GTK bookmarks for them show again. Only what Places already lists is left out.
  • Pins reorder by dragging a pin up or down. The new order is written back into GTK's bookmarks, moving only the pins' own lines, so remote bookmarks and Omarchy's seeded ones keep their place.
  • Right-click on a place or pin: Open, Open Terminal Here, Copy Path, and Unpin for pins.
  • New home and desktop glyphs.

#19 also turns Home into a row; this goes further by dropping the per-folder list, so whichever lands first, the other can rebase onto it.

Tests

placesListEveryFolderInHome becomes placesListHomeAndItsStandardFolders, and placesReorderPins covers the reorder, labels and remote lines included. The suite passes.

Fixes #76

…n home

Places is now Home, the XDG folders that exist, Recents and Trash, as in
Nautilus. Other folders in home can be pinned, so GTK bookmarks seeded
from Nautilus show again. Pins reorder by dragging, and places and pins
have a right-click menu: Open, Open Terminal Here, Copy Path, Unpin.

Fixes omacom#76
@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; both previous findings are fixed and no new actionable issues were found.

Summary

The PR replaces the full list of folders under Home with Home and its standard folders.

  • The sidebar lists Home and existing standard folders before Recents and Trash.
  • Folders outside Places can appear as pins, including folders inside Home.
  • Dragging a pin changes its saved order without moving other bookmarks.
  • Places and pins open folder menus from a right-click or keyboard shortcut.

Both previous findings are addressed. No new actionable issues were found in the changes since the previous review. Tests were inspected, not run.

Reviews (2) · Last reviewed commit: "Open a place's or pin's menu from the ke..." · Reviewed by Greptile

Comment thread src/places.cpp Resolved
Comment thread src/Sidebar.qml Resolved
…es when moving it

Menu, Shift+F10 and Alt+Enter open the menu on a place or pin beside it,
as they do on a drive. A folder bookmarked twice could keep its old place
after a move, since only its first line moved; its later copies go now.
@omarchybot omarchybot added the enhancement New feature or request label Nov 15, 2026
@dhh

dhh commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Thank you for this, and for the careful write-up. We went the other way on purpose: in #158 Home keeps listing every folder in home, and any of them can be hidden (or renamed, unpinned, trashed) from the sidebar's right-click menu, with Show in Home bringing it back. That keeps the sidebar matching what's actually in home while still letting you trim the folders you don't use, so I'm closing this one. Thanks again!

@dhh dhh closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let me pick which folders the sidebar shows

3 participants