Repository navigation
Conversation
…n home Places is now Home, the XDG folders that exist, Recents and Trash, as in Nautilus. Other folders in home can be pinned, so GTK bookmarks seeded from Nautilus show again. Pins reorder by dragging, and places and pins have a right-click menu: Open, Open Terminal Here, Copy Path, Unpin. Fixes omacom#76
[Medium impact] The PR appears safe to merge; both previous findings are fixed and no new actionable issues were found. SummaryThe PR replaces the full list of folders under Home with Home and its standard folders.
Both previous findings are addressed. No new actionable issues were found in the changes since the previous review. Tests were inspected, not run. Reviews (2) · Last reviewed commit: "Open a place's or pin's menu from the ke..." · Reviewed by Greptile |
…es when moving it Menu, Shift+F10 and Alt+Enter open the menu on a place or pin beside it, as they do on a drive. A folder bookmarked twice could keep its old place after a move, since only its first line moved; its later copies go now.
|
Thank you for this, and for the careful write-up. We went the other way on purpose: in #158 Home keeps listing every folder in home, and any of them can be hidden (or renamed, unpinned, trashed) from the sidebar's right-click menu, with Show in Home bringing it back. That keeps the sidebar matching what's actually in home while still letting you trim the folders you don't use, so I'm closing this one. Thanks again! |
The sidebar lists every folder in home under Home. With a few dozen folders, the ones used daily are buried and Pinned sits below them all (#76). Bookmarks seeded from Nautilus for top-level home folders are also skipped as "already under Home", so pinning can't fix it.
What changes
homeanddesktopglyphs.#19 also turns Home into a row; this goes further by dropping the per-folder list, so whichever lands first, the other can rebase onto it.
Tests
placesListEveryFolderInHomebecomesplacesListHomeAndItsStandardFolders, andplacesReorderPinscovers the reorder, labels and remote lines included. The suite passes.Fixes #76