Repository navigation
Conversation
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryAncestor columns now wait until they approach the visible area before creating their folder models, then keep those models and their scroll positions.
No actionable issues found. Reviews (3) · Last reviewed commit: "Load hidden ancestor models only when fi..." · Reviewed by Greptile |
|
Thanks for this. Most paths are a handful of folders deep, where loading every ancestor costs little; the 24-deep case is rare. What's new on main, and probably the clearest win now, is those hidden columns: each still makes a model and reads its folder although nothing shows it. A PR that gives an ancestor column a model only once it's in view (or near it), without the retention budget, keeping scroll position, the trail's highlight and drops working, measured against main for a place picked deep in the sidebar, would be much easier to take. Its tests should go in |
0e0e8b4 to
f67ae06
Compare
|
Thanks. I rebuilt this around the hidden ancestors on main ( For sidebar picks into synthetic folders with 500 files per ancestor, median time to the first visible QML row was 9.9 → 2.0 ms at 3 levels and 11.6 → 2.5 ms at 8 levels. That creates 2 models instead of 4 and 9. These are offscreen LTR measurements, with eight paired runs per case; RTL gave similar results. They measure QML readiness, not monitor frame presentation. The regression is in |
f67ae06 to
2c53c3f
Compare
Summary
Defer hidden ancestor listings after a sidebar place is picked. Keep each
model once first approached; no retention budget or eviction policy.
Evidence
5179c58becausehidden ancestors instantiate models.
After: first-load freshness, offscreen trail reveal, scroll retention
and a real file drop pass in tests/folio_tests.cpp, without a new target.
direction, Qt 6.12 Release/offscreen/software, warm file cache. LTR medians:
RTL results are comparable. These measure QML readiness, not monitor frame
presentation or completed thumbnails. Current and peek columns are unchanged.
Full local
bin/test: 243 passed, 0 failed, 1 skipped (root-drive trash needs writable /).The Qt plugin set uses package-owned qt6-base/imageformats/svg image handlers;
this is local qualification, not a container CI run. One theme-watcher failure
in the shared temporary directory was reproduced on the unpatched main test
when its temporary parent changed. The full suite passes with a private
TMPDIR.Merge Danger
Door: Two-way
Local QML change; no stored data or new dependency.
Blast Radius: Columns
First listing timing for hidden ancestors; models already shown retain their
existing lifetime. LTR/RTL, trail highlighting, sorting, sidebar navigation,
peek behavior and drops are covered by the new and existing suite.