Repository navigation
Conversation
[Medium impact] The PR appears safe to merge; no new blocking issues were found. SummaryThe list now reuses rows while keeping each file’s clicks, thumbnails, and drag data separate.
The earlier thumbnail-test finding is addressed. No new actionable issues found. Tests were not run during this review.
|
|
Thanks for this, and for the careful thinking about what a reused row must forget. The list has changed under it since: it's a tree now (#160), so
If the win holds up on the tree with that, it can go in. |
98628c2 to
7c2593c
Compare
|
Thanks. I rebased the original reuse change onto the current tree and moved the tests into For the long-scroll measurement, I used an expanded 2,320-row tree with synthetic PNG/text files and the same 7,680-pixel, two-second scroll on both versions. Across three viewport configurations, median GUI CPU fell from 120–124 ms to 34–40 ms, and the median per-run p95 interval between Qt frame-swap notifications fell from 20.9–21.1 ms to 16.7 ms. This used NVIDIA OpenGL in a private Weston session with a virtual 60 Hz output, eight alternating pairs per configuration. Neither version had an interval over 25 ms; this measures application-side timing, not physical display FPS. There is still a tradeoff: earlier software-rendered runs improved tall-list settling from about 8 to 6.5 ms, but the short mixed list went from 5.3 to 5.8 ms, and the first jump to the end from 8.7 to 11.9 ms. I wouldn't claim a win in every scenario. |
Summary
Reuse the list's Qt delegates without carrying one file's interaction state into another. Rebased onto the expandable tree at
905999e.Active drags temporarily use the existing non-reusing policy. Tree roles and general file thumbnails are preserved. No timers or cacheBuffer changes.
Evidence
After: 34–40 ms GUI CPU and 16.7 ms p95. 48 measured processes, 8 alternating pairs per 480 px LTR / 960 px LTR / 960 px RTL viewport. NVIDIA OpenGL/default threaded Qt 6.12, private Weston virtual 60 Hz. Whole-process CPU fell from 233–241 to 139–147 ms. Neither version had intervals over 25 ms. These are application-side notifications, not physical display FPS or proof of avoided skipped refreshes.
480a319; do not claim all workloads/platforms improve.After: focused cases 11 passed at 1× and 2×; full existing
bin/test: 258 passed / 0 failed / 1 environment-dependent root-trash skip. Tests check picture reuse/pixels, pooled cleanup, tree depth and visible arrows, double-click identity, releases and late grabs.Merge Danger
Door: Two-way. No stored format changes or new dependency.
Blast Radius: List. Shared FileRow input/drag code also serves columns; the complete suite passes. Per-row pooled/generation/pressed-path state and the in-suite regressions are the maintenance cost. Equal-distance GPU timing is controlled; the benchmark does not establish physical presentation timing or native-wheel performance.
Manual A/B acceptance passed the three scroll/tree scenarios. The subjective impression of quicker scrolling is not a blind measurement.
A separate native Page Down/Page Up replay during live acceptance reproduced an
existing crash in unpatched main (Qt render-thread signal-connection cleanup).
The exact PR binary completed all four 360-key replay runs. The underlying
cause remains incompletely isolated; this PR does not claim to fix that crash.