Repository navigation
Make Backend::showItem invokable from QML - #136
Conversation
Clicking a file in the column showing the selected folder's contents called showItem from QML, which failed with "Property 'showItem' of object Backend is not a function". The test calls it through the meta-object system, as QML does. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
[Low impact] The latest changes appear safe to merge. SummaryMakes
Reviews (2) · Last reviewed commit: "Call showItem through the meta-object sy..." · Reviewed by Greptile |
The existing test called showItem from C++, which never needed Q_INVOKABLE. Calling it the way QML does makes that one test cover both what showItem does and that QML can reach it, so the second test is dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for splitting this out, @OmarGonD. I reviewed it and pushed one commit to shorten the test: 371e5f1. What 371e5f1 changes. Your new test repeated What was run, on a disposable Omarchy VM:
Second opinion. Codex at medium effort reviewed the diff read-only and found nothing to change. It agrees Related. #116 no longer carries this change. #128 fixes a different failure: a cold Show in folder request over D-Bus, which reaches Waiting on. The Test workflow is waiting for a maintainer to approve the run. After that, it's the maintainer's call. |
|
The |
Picking Dropbox in the sidebar showed ~ as the first column, Dropbox beside it, then its contents. The place picked is now the first column in sight, with the folders above it scrolled out to the left, there to scroll back to. Going deeper keeps it first; going up past it (with ←, or ~ in the path bar) shows what's above again. The details column, filling the rest of the window, counts only the columns in sight. Also covered now: a click on a folder in the last column (the selected folder's contents) goes into it. Installed builds from before #136 didn't. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picking Dropbox in the sidebar showed ~ as the first column, Dropbox beside it, then its contents. The place picked is now the first column in sight, with the folders above it scrolled out to the left, there to scroll back to. Going deeper keeps it first; going up past it (with ←, or ~ in the path bar) shows what's above again. The details column, filling the rest of the window, counts only the columns in sight. Also covered now: a click on a folder in the last column (the selected folder's contents) goes into it. Installed builds from before #136 didn't. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Clicking a file in the column that shows what's inside the selected folder (columns view) did nothing: the journal logs
TypeError: Property 'showItem' of object Backend is not a function. AddingQ_INVOKABLEfixes it.The test calls
showItemthroughQMetaObject::invokeMethod, as QML does; the existing C++ test bypassed the meta-object system.Split out of #116 at the reviewer's suggestion.
🤖 Generated with Claude Code