Repository navigation
Show a cached picture while the original preview loads - #140
Conversation
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryThe preview now shows a cached thumbnail while the original picture loads.
No new actionable issues found. The two earlier findings are addressed. Reviews (6) · Last reviewed commit: "Show the existing thumbnail while a prev..." · Reviewed by Greptile |
0b33019 to
0607aec
Compare
|
Thanks, Clayton. A blank Space preview while a big picture decodes is worth fixing. Since this was opened, the details column got the same treatment in #155: it shows the 128px thumbnail from the existing To make it mergeable, please redo it on top of #139 once that lands, rebased on main. Put an |
0607aec to
961faab
Compare
0adb031 to
23f0f6f
Compare
|
Thanks, David. I rebased #140 onto main after #139 landed and switched Space preview to the existing I extended the shared-decode regression to cover the thumbnail handoff. It passed at 1× and 2×, and the full local suite passed. Ready for another look. |
23f0f6f to
cb39e20
Compare
|
Before/after of the preview window on today's main (this branch merged locally onto it), captured while the original is still decoding: a made-up 4800×3200 |

Space preview shows a cached thumbnail while Qt decodes the original. It reuses the details pane’s
thumbprovider and builds on the shared-decode fix from #139.The preview checks existing thumbnail buckets without writing to the cache. It reads the original’s upright dimensions from its header to size the placeholder, so a small picture stays at its actual size. Qt delivers both requests on the same image reader, so the thumbnail gets up to 50 ms to arrive before the original starts.
The tests cover a read-only cache miss, a hit in a larger bucket, the size of a small picture through the handoff, and sharing the original’s in-flight decode across a reload. The handoff passed offscreen at 1× and 2×, and the full local suite passed.