Skip to content

Draw file names as plain text - #177

Open
dhh wants to merge 2 commits into
mainfrom
plain-names
Open

dhh wants to merge 2 commits into
mainfrom
plain-names

Conversation

@dhh

@dhh dhh commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

A file named like markup, such as `bold.txt`, drew as rich text, bold and without its tag, because the labels that show names took Text's AutoText default, which guesses from the text whether it's markup. Every label that shows a file, folder, drive or app name, and the lines that quote one (the notice, a dialog's title, a rename's problem, the search field's hint and a search that found nothing), now draws plain text.

Based on #55 by @thisisgm.

🤖 Generated with Claude Code

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no blocking issues were found.

Summary

File, folder, drive, and app names now display as literal text, so names that resemble markup keep their tags and characters.

  • File names and related labels now show markup as plain text.

No new actionable issues found. Tests were inspected but not run.

Reviews (5) · Last reviewed commit: "Draw the preview window's extension as p..." · Reviewed by Greptile

Comment thread src/PreviewWindow.qml Resolved
dhh and others added 2 commits November 18, 2026 17:27
A file named like markup, such as "<b>bold.txt", drew as rich text, bold
and without its tag, because the labels that show names took Text's
AutoText default, which guesses from the text whether it's markup. Every
label that shows a file, folder, drive or app name, and the lines that
quote one (the notice, a dialog's title, a rename's problem, the search
field's hint and a search that found nothing), now draws plain text.

Co-Authored-By: GM <gianmarcomorales@icloud.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A file with no preview shows its extension under a plain glyph, and that
label still took AutoText: a file named "x.<b>ty" showed a bold "TY"
without its tag. It now draws plain text, as the grid's badges do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dhh

dhh commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Before (main) on the left, after (this branch) on the right, with made-up files named <b>bold.txt, <i>tilted.png, <font color=red>red alert.md and <s>struck out.txt. On main the names draw bold, italic and struck through with their tags hidden; here they read exactly as named.

List view:

List view before and after

Columns view, where the details column title shows the same:

Columns view and details before and after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant