Skip to content

Stop a thumbnailer past its time with what it started - #182

Open
dhh wants to merge 1 commit into
thumbnail-failures-judgedfrom
thumbnailer-stop-group
Open

dhh wants to merge 1 commit into
thumbnail-failures-judgedfrom
thumbnailer-stop-group

Conversation

@dhh

@dhh dhh commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Based on #67 by @thisisgm. Stacked on #176, whose run helper it extends.

A thumbnailer still running after 15 seconds was killed alone, so the programs it had started (glycin and the office thumbnailer start their own) ran on. Each now runs in a process group of its own, and past its time the whole group is stopped, as plugin commands already are.

🤖 Generated with Claude Code

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Thumbnail helpers now run in their own process groups, so a timeout stops both the helper and the programs it started.

  • Thumbnail timeouts stop the command and its helper processes.

No actionable issues found. Tests were not run.

Reviews (3) · Last reviewed commit: "Stop a thumbnailer past its time with wh..." · Reviewed by Greptile

@dhh
dhh force-pushed the thumbnailer-stop-group branch from c25250f to 585c1e5 Compare November 18, 2026 15:03
A thumbnailer still running after 15 seconds was killed alone, so the
programs it had started (glycin and the office thumbnailer start their
own) ran on. Each now runs in a process group of its own, and past its
time the whole group is stopped, as plugin commands already are.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dhh
dhh force-pushed the thumbnail-failures-judged branch from 2c0a169 to 66a3ad4 Compare November 18, 2026 16:23
@dhh
dhh force-pushed the thumbnailer-stop-group branch from 585c1e5 to 7737be3 Compare November 18, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants