Repository navigation
Conversation
[Medium impact] The PR appears safe to merge. SummaryThumbnail helpers now run in their own process groups, so a timeout stops both the helper and the programs it started.
No actionable issues found. Tests were not run. Reviews (3) · Last reviewed commit: "Stop a thumbnailer past its time with wh..." · Reviewed by Greptile |
dhh
force-pushed
the
thumbnailer-stop-group
branch
from
November 18, 2026 15:03
c25250f to
585c1e5
Compare
A thumbnailer still running after 15 seconds was killed alone, so the programs it had started (glycin and the office thumbnailer start their own) ran on. Each now runs in a process group of its own, and past its time the whole group is stopped, as plugin commands already are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dhh
force-pushed
the
thumbnail-failures-judged
branch
from
November 18, 2026 16:23
2c0a169 to
66a3ad4
Compare
dhh
force-pushed
the
thumbnailer-stop-group
branch
from
November 18, 2026 16:23
585c1e5 to
7737be3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #67 by @thisisgm. Stacked on #176, whose run helper it extends.
A thumbnailer still running after 15 seconds was killed alone, so the programs it had started (glycin and the office thumbnailer start their own) ran on. Each now runs in a process group of its own, and past its time the whole group is stopped, as plugin commands already are.
🤖 Generated with Claude Code