Repository navigation
Conversation
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryThumbnailers now match files when their declared file type is an alias of the name Folio uses.
The earlier test compatibility issue is fixed. No new actionable issues were found. Reviews (3) · Last reviewed commit: "Test aliases with names every MIME datab..." · Reviewed by Greptile |
A thumbnailer that names a type only by an alias never matched the canonical name Folio asks with, so glycin's image/x-dds left a DDS file blank, and WAV audio missed the thumbnailer it had. The declared types are resolved to canonical names once, when the thumbnailers are read. Within one folder a .thumbnailer file that names the type itself still wins over one that names an alias of it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test took video/matroska and audio/vnd.wave to be the canonical names, which they are only in newer shared-mime-info; with 2.2 the x- names are, and the test failed with the code working. Which file wins within one folder is now checked with comic book RAR archives, whose canonical name and x-cbr alias have stood for years. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dhh
force-pushed
the
thumbnailer-aliases
branch
from
November 18, 2026 16:25
41f81f3 to
3bca716
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #66 by @thisisgm.
A thumbnailer that names a type only by an alias never matched the canonical name Folio asks with, so glycin's image/x-dds left a DDS file blank, and WAV audio missed the thumbnailer it had. The declared types are resolved to canonical names once, when the thumbnailers are read. Within one folder a .thumbnailer file that names the type itself still wins over one that names an alias of it.
🤖 Generated with Claude Code