Repository navigation
Stop the trash menu from showing two rules in a row - #194
Open
itscallssh wants to merge 1 commit into
Open
itscallssh wants to merge 1 commit into
itscallssh wants to merge 1 commit into
Conversation
[Medium impact] This PR appears safe to merge; no actionable issues were found. SummaryThis PR cleans up menu separators when menus open and hides Open Terminal Here for folders in the Trash.
No actionable issues found. Reviews (1) · Last reviewed commit: "Stop the trash menu from showing two rul..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right-clicking a file in the Trash showed two separator lines in a row above
Delete….
The menu has a group of entries between Copy Path and Trash (Compress,
Share, Open Terminal Here and so on). In the Trash all of them are hidden,
but the rules around the group stayed, so two met.
FolioMenunow tidies its rules each time it opens: none at the top orbottom, and only one where several would meet. This also removes a stray
rule at the bottom of the menu when right-clicking empty space in the Trash.
It applies to every menu, not just this one.
Also hides Open Terminal Here on a folder in the Trash, where it shouldn't
show.
Tested by right-clicking a file, a folder and empty space in the Trash, and
the same in a normal folder.
Before:


Now: