Skip to content

Stop the trash menu from showing two rules in a row - #194

Open
itscallssh wants to merge 1 commit into
omacom:mainfrom
itscallssh:fix-trash-menu-double-rule
Open

itscallssh wants to merge 1 commit into
omacom:mainfrom
itscallssh:fix-trash-menu-double-rule

Conversation

@itscallssh

Copy link
Copy Markdown

Right-clicking a file in the Trash showed two separator lines in a row above
Delete….

The menu has a group of entries between Copy Path and Trash (Compress,
Share, Open Terminal Here and so on). In the Trash all of them are hidden,
but the rules around the group stayed, so two met.

FolioMenu now tidies its rules each time it opens: none at the top or
bottom, and only one where several would meet. This also removes a stray
rule at the bottom of the menu when right-clicking empty space in the Trash.
It applies to every menu, not just this one.

Also hides Open Terminal Here on a folder in the Trash, where it shouldn't
show.

Tested by right-clicking a file, a folder and empty space in the Trash, and
the same in a normal folder.

Before:
screenshot-2026-11-19_01-25-10
Now:
image

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; no actionable issues were found.

Summary

This PR cleans up menu separators when menus open and hides Open Terminal Here for folders in the Trash.

  • Folio menus keep rules between visible entries only.
  • Trash folders no longer show the terminal command.

No actionable issues found.

Reviews (1) · Last reviewed commit: "Stop the trash menu from showing two rul..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant