Skip to content

Let the list view's rows be sized in three steps like the grid's tiles - #195

Open
itscallssh wants to merge 1 commit into
omacom:mainfrom
itscallssh:list-view-sizes
Open

itscallssh wants to merge 1 commit into
omacom:mainfrom
itscallssh:list-view-sizes

Conversation

@itscallssh

Copy link
Copy Markdown

The grid's tiles can be made bigger or smaller, but the list's rows could not.

The list now has three sizes: normal (as before), bigger and biggest. Ctrl+=,
Ctrl+-, Ctrl+0 and Ctrl+scroll work on the list as they do on the grid. Rows
and their pictures grow; the name and details stay the same size, as in the
grid. The list's size is remembered separately from the grid's, and a new
split pane starts with it.

  • Each level of an open folder is indented by the picture's width, so its
    items start under the folder's own picture at any size.
  • Ctrl+scroll moved into ZoomWheel.qml, shared by the grid and the list.
  • The help text now says "tiles and rows".

Now:

screenrecording-2026-11-19_02-10-12_trimmed.mp4

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The change affects sizing and scrolling in the file browser's list and grid views.

The PR appears safe to merge, with two non-blocking improvements.

Fix All in CursorFindings

  1. P2 Help text loses its translations ▶
  2. P2 New sizes have no tests ▶

Summary

Adds three list-row sizes, remembered separately from grid tiles, with keyboard and Ctrl+scroll controls.

  • List rows now grow through three sizes alongside grid tiles.

Two non-blocking improvements remain: translate the changed help text and add tests for the new sizing behavior.

Reviews (1) · Last reviewed commit: "Let the list view's rows be sized in thr..." · Reviewed by Greptile

Comment thread src/HelpOverlay.qml
{ title: qsTr("View"), shortcuts: [
[qsTr("Columns, list or grid"), [["Ctrl", "1"], ["Ctrl", "2"], ["Ctrl", "3"]]],
[qsTr("Bigger, smaller or normal tiles"), [["Ctrl", "="], ["Ctrl", "-"], ["Ctrl", "0"]]],
[qsTr("Bigger, smaller or normal tiles and rows"), [["Ctrl", "="], ["Ctrl", "-"], ["Ctrl", "0"]]],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Help text loses its translations. This changes the lookup key, but only the English catalog gets the new key. Other languages still translate the old text, so this help entry now appears in English. Update the other catalogs to include the new wording.

Fix in Cursor

Comment thread tests/folio_tests.cpp
width: 900; height: 620; visible: true
property string viewMode: "list"
property real zoom: 1
property real listZoom: 1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 New sizes have no tests. The test changes only add listZoom to existing windows; none changes it or checks the new controls. Add a test that steps through heights 32, 48, and 64, checks the end stops and Ctrl+0, and confirms that switching views leaves the grid size unchanged. Otherwise the suite can pass even if the new controls stop resizing rows.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant