Repository navigation
Let the list view's rows be sized in three steps like the grid's tiles - #195
itscallssh wants to merge 1 commit into
Conversation
[Medium impact] The change affects sizing and scrolling in the file browser's list and grid views. The PR appears safe to merge, with two non-blocking improvements.
|
| { title: qsTr("View"), shortcuts: [ | ||
| [qsTr("Columns, list or grid"), [["Ctrl", "1"], ["Ctrl", "2"], ["Ctrl", "3"]]], | ||
| [qsTr("Bigger, smaller or normal tiles"), [["Ctrl", "="], ["Ctrl", "-"], ["Ctrl", "0"]]], | ||
| [qsTr("Bigger, smaller or normal tiles and rows"), [["Ctrl", "="], ["Ctrl", "-"], ["Ctrl", "0"]]], |
| width: 900; height: 620; visible: true | ||
| property string viewMode: "list" | ||
| property real zoom: 1 | ||
| property real listZoom: 1 |
There was a problem hiding this comment.
New sizes have no tests. The test changes only add
listZoom to existing windows; none changes it or checks the new controls. Add a test that steps through heights 32, 48, and 64, checks the end stops and Ctrl+0, and confirms that switching views leaves the grid size unchanged. Otherwise the suite can pass even if the new controls stop resizing rows.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
The grid's tiles can be made bigger or smaller, but the list's rows could not.
The list now has three sizes: normal (as before), bigger and biggest. Ctrl+=,
Ctrl+-, Ctrl+0 and Ctrl+scroll work on the list as they do on the grid. Rows
and their pictures grow; the name and details stay the same size, as in the
grid. The list's size is remembered separately from the grid's, and a new
split pane starts with it.
items start under the folder's own picture at any size.
ZoomWheel.qml, shared by the grid and the list.Now:
screenrecording-2026-11-19_02-10-12_trimmed.mp4