Repository navigation
Thumbnails: camera RAW, a checked cache, clearer misses #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a9f9ec7
Check a cached thumbnail belongs to its file
thisisgm bb07eca
Try again what an older Folio couldn't thumbnail
thisisgm c3ddaa3
Find a thumbnailer through its type's aliases
thisisgm 3621993
Thumbnail camera RAW from its embedded JPEG
thisisgm a6c33d8
Name the package that would draw a missing thumbnail
thisisgm 691c01b
Let a thumbnailer installed later draw what failed
thisisgm 18b61c5
Turn a RAW preview by its own directory's orientation
thisisgm bb0f83c
Name no package for a PDF that pdftoppm draws
thisisgm e03729b
Merge origin/main into the RAW thumbnails branch
dhh 2cda48c
Read an embedded JPEG's own turn from IFD0, past any fill bytes
dhh 99935cd
Clear away the failure markers an older Folio left
dhh 9f0c26c
Say where the table of packages' types was copied from
dhh 3b3d7ed
Leave a newer Folio's failures, and never follow a link out of the cache
dhh b94340b
Bound what a hostile RAW can cost the reader
dhh 6b4f84c
Say a .thumbnailer file names the alias, not the spec
dhh 7fdbc27
Never clear failure markers through a fail folder that is a link
dhh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| #pragma once | ||
|
|
||
| #include <QImage> | ||
| #include <QString> | ||
|
|
||
| // Camera RAW thumbnails from the embedded JPEG, found in the TIFF directories of CR2 NEF NRW ARW SR2 DNG PEF. | ||
| namespace RawEmbed { | ||
|
|
||
| bool handles(const QString &mime); | ||
|
|
||
| // The largest valid embedded JPEG, upright and at most `pixels` on its longer side; null when the file holds none. | ||
| QImage thumbnail(const QString &path, int pixels); | ||
|
|
||
| } // namespace RawEmbed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.