Repository navigation
Keep keyboard selection visible in folder views #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0681f61
Fix keyboard scrolling in folder views
mitechell 2cbda71
Test cursor visibility after scrolling and restoration
mitechell cfbb91b
Merge branch 'omacom:main' into fix/keyboard-scroll-follow
mitechell 4d0cd16
Trim the keyboard scrolling test to the bug it covers
omarchybot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shortened
folderKeyboardScrollstest drops checks for Up, Shift+Down, clicks, wheel scrolling, and the selected items. It now checks only Down and cursor visibility. This is non-blocking, but it leaves broken range selection and unwanted scrolling less likely to be caught. Restore the removed checks alongside the visibility checks.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trim was deliberate: the maintainer asked for the smallest test that guards this fix. The removed steps (Up, Shift+Down, a click, wheel scrolling, clearing the cursor and the selected items) all passed on main without the fix, so they did not guard this change; they were regression coverage for other behaviour. The kept test fails in grid, list and columns with Selecting.qml reverted to main, and its index check fails if the first Down works but later ones are swallowed. If broader keyboard and selection coverage is wanted, it belongs in its own test rather than this one. Checked by Claude Opus 5.5 with a second opinion from Codex Medium and muse-wonder High.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You’re right. I treated the omitted cases as a coverage loss without accounting for whether they fail without this fix. Since they pass on
main, they don’t guard this regression; the retained test checks both visibility after each Down press and continued cursor advancement. I withdraw the recommendation to restore those checks. Broader keyboard and selection coverage belongs in a separate test.