Repository navigation
Conversation
Hyprland starts a fresh axis event, with the wheel as its source, on every virtual pointer `axis` request, and `axis_source` writes into the event of the last axis named. Sent first, the source was dropped, so a touchpad scroll reached the remote as a wheel: no kinetic scrolling, and mouse_up/mouse_down binds fired while scrolling. Fixes omacom#112. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCs6nfZCNssaXtUYR7cpHg
[Medium impact] The PR appears safe to merge; no blocking issues remain. SummarySends
Reviews (2) · Last reviewed commit: "Test that a scroll's axis source follows..." · Reviewed by Greptile |
The input thread's socket test decodes every request now, not only key requests, so the pointer's request order can be checked: the source after axis, axis_discrete and axis_stop, then frame, on either axis. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCs6nfZCNssaXtUYR7cpHg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112.
Problem
The server's virtual pointer sent
axis_sourcebeforeaxis. Hyprland (checked on v0.57.2,src/protocols/VirtualPointer.cpp) builds a fresh axis event with the wheel as its source on everyaxisrequest, andsetAxisSourcewrites intom_axisEvents[m_axis], the event of the last axis named. A source sent first was dropped, or landed on the other axis after a change of direction. A touchpad scroll from the client reached the remote as a wheel with no discrete value: no kinetic scrolling, andmouse_up/mouse_downbinds fired during a touchpad scroll.Fix
Send
axis_sourceafteraxis/axis_discrete/axis_stopand beforeframe(), as proposed in the issue.axis_discreteandaxis_stopkeep the event's source in Hyprland, so the wheel path behaves as before.Testing
scripts/check.shpasses. New testthread::tests::axis_source_follows_the_axisdecodes the pointer's requests from a socket peer and checksaxis/axis_discrete/axis_stop, thenaxis_source, thenframe, on both axes. With the old order it fails ([5, 3, 4]against[3, 5, 4]). To share the socket setup with the keyboard test,requestsnow decodes every request andkey_requestsfilters it.I checked the ordering against Hyprland's source but did not verify it live: nothing on one machine reports which axis source a remote app receives. I did not run
scripts/e2e.sh, since this doesn't touch the video path.The change was written with Claude Opus 5.5.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UCs6nfZCNssaXtUYR7cpHg