Repository navigation
Conversation
A headless session hides the local pointer, so the only one left is the remote pointer drawn into the frames, and every move waits for a round trip through the encoder before it shows. --show-local-pointer keeps the local pointer visible as well: it moves with no delay and the remote one trails it. The default stays as it is. Fixes omacom#126. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCs6nfZCNssaXtUYR7cpHg
[Low impact] The PR appears safe to merge. SummaryAdds
No actionable issues found. Review was based on source inspection; live cursor behavior was not tested. Reviews (1) · Last reviewed commit: "Keep the local pointer on a headless scr..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126.
Problem
On a
--headlesssession the client hides the local pointer (#38, background in #28), so the only visible pointer is the one Hyprland draws into the frames. Every move has to reach the server and come back through the encoder and decoder before it shows, which feels sluggish even on a LAN. Some people would rather see two pointers, as other remote desktop tools show them.Fix
A new
--show-local-pointerflag. With it, the two places that set the transparent cursor on a headless session leave the local pointer alone: the one on connect, and the fallback inset_remote_cursorwhen the server sends no visible cursor image. A visible remote cursor image still replaces the local pointer, as on a mirrored session. Without the flag nothing changes.It is a flag rather than an environment variable or a
config.tomlkey, as the issue suggests:config.tomlis written by gliff and not meant to be edited, and the other display choices (--headless,--output) are flags too. The README mentions it next to the private screen.Testing
scripts/check.shpasses. Not verified live: with client and server on one nested Hyprland, the server's virtual pointer and the local pointer are the same seat cursor, so the difference does not show. The reporter's patch in the issue makes the same change at the same two sites behind an environment variable, and they report it working on v0.4.2.The change was written with Claude Opus 5.5.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UCs6nfZCNssaXtUYR7cpHg