Skip to content

Show the probe's output when the e2e pipeline check fails - #145

Open
Unayung wants to merge 1 commit into
omacom:mainfrom
Unayung:fix/e2e-show-pipeline-output
Open

Unayung wants to merge 1 commit into
omacom:mainfrom
Unayung:fix/e2e-show-pipeline-output

Conversation

@Unayung

@Unayung Unayung commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Part of #140.

Problem

Section 2 of scripts/e2e.sh discards the probe's stderr and, on failure, prints only E2E FAIL: 4:4:4 pipeline (gpu). The PSNR score and the probe's error never reach the log, so an intermittent failure like the one in #140 can't be reported with numbers.

Fix

Keep the probe's stderr in pipe and print pipe to stderr before fail in both failure checks. Section 2's result and output are unchanged when it passes.

Not in this PR

The 26.5 dB score on rotated outputs on the Meteor Lake iGPU. I don't have that hardware.

Testing

  • bash -n scripts/e2e.sh and scripts/check.sh pass.
  • I ran run_pipeline as extracted from the script against a stub probe and a stub hyprctl:
    • A probe that prints a FAIL line and an error on stderr now shows the decoded line with the PSNR score, the FAIL line, Error: pipeline PSNR too low, then E2E FAIL: 4:4:4 pipeline (gpu).
    • A probe that prints PASS returns without output, as before.
    • Output with neither PASS nor FAIL is printed before the failure.
  • I did not run the full e2e suite for this change.

🤖 Generated with Claude Code

https://claude.ai/code/session_01UCs6nfZCNssaXtUYR7cpHg

Section 2 dropped the probe's stderr and printed only the section name
on failure, so a failing run left no PSNR score or error to report
(omacom#140). Keep stderr and print the probe's output before failing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UCs6nfZCNssaXtUYR7cpHg
@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This diagnostic-only change appears safe to merge.

Summary

Updates scripts/e2e.sh to keep the probe's stderr and show its full captured output when either pipeline check fails.

  • Pipeline failures now include the probe's output.

Reviews (1) · Last reviewed commit: "Show the probe's output when the e2e pip..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant