Repository navigation
Conversation
Section 2 dropped the probe's stderr and printed only the section name on failure, so a failing run left no PSNR score or error to report (omacom#140). Keep stderr and print the probe's output before failing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCs6nfZCNssaXtUYR7cpHg
[Low impact] This diagnostic-only change appears safe to merge. SummaryUpdates
Reviews (1) · Last reviewed commit: "Show the probe's output when the e2e pip..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #140.
Problem
Section 2 of
scripts/e2e.shdiscards the probe's stderr and, on failure, prints onlyE2E FAIL: 4:4:4 pipeline (gpu). The PSNR score and the probe's error never reach the log, so an intermittent failure like the one in #140 can't be reported with numbers.Fix
Keep the probe's stderr in
pipeand printpipeto stderr beforefailin both failure checks. Section 2's result and output are unchanged when it passes.Not in this PR
The 26.5 dB score on rotated outputs on the Meteor Lake iGPU. I don't have that hardware.
Testing
bash -n scripts/e2e.shandscripts/check.shpass.run_pipelineas extracted from the script against a stub probe and a stubhyprctl:Error: pipeline PSNR too low, thenE2E FAIL: 4:4:4 pipeline (gpu).🤖 Generated with Claude Code
https://claude.ai/code/session_01UCs6nfZCNssaXtUYR7cpHg