Skip to content

kboot: give the J516M the T6034 display and GPU defaults (stacked on #24) - #28

Draft
BTNG-studio wants to merge 1 commit into
omacom:chris/j514m-t6034-20261105from
BTNG-studio:j516m-display-gpu
Draft

BTNG-studio wants to merge 1 commit into
omacom:chris/j514m-t6034-20261105from
BTNG-studio:j516m-display-gpu

Conversation

@BTNG-studio

@BTNG-studio BTNG-studio commented Nov 7, 2026 •

Copy link
Copy Markdown

Summary

Give the J516M (16" binned M3 Max) the T6034 display and GPU defaults that #24 gives the J514M. The J516M has the same T6034 die: its ADT names the same DCP image (F493F03E-…), and the T6034 handoff registers #24 checks match on it.

Stacked on #24. It targets #24's branch, so the diff is this one commit.

 src/kboot.c                  m3_max14_boards: j514m
+                                              j516m
 src/kboot_display_handoff.c  dcp_boards_t6034: j514m
+                                              j516m      (boards_desc "J514M/J516M")
 src/kboot_t6031.c            t6034_board(): apple,t6034 and j514m
+                                                     or j516m

Owner choices work as on the J514M: chosen.asahi,t6034-gpu=0, -dcp=0 and asahi,m3-defaults=0 opt out, and a lost config drops the defaults.

Kernel side: omacom/linux-aurora#405 (stacked on omacom/linux-aurora#372). Ship order: this must not ship before that kernel. A J516M with this m1n1 and an older kernel gets the handoff but no board record, and stays on the boot framebuffer.

Evidence

Hardware: my J516M (Mac15,11), iBoot OS firmware 14.7, system firmware 27.0.

  • What ran: this change on Add normal J514M/T6034 graphics handoff #24's head 9488b7b7, as local m1n1-aurora 1.6.1.aurora22-103 (m1n1 stage 2), every boot since 2026-11-06 with the kernel side. Add normal J514M/T6034 graphics handoff #24's head hasn't moved since, so this is the source that booted, plus test updates and one comment's wording.
    apple-t6034-display: handoff: PMP values /chosen/asahi,t6034-pmp: board-id 0x46 … 72 tunables (image pinned: 07FF4C5B-…)
    apple-dcp 386c00000.dcp: J516M display started: 3456x2234@120, 74 notch rows shown, 346x223 mm
    asahi-g15 40a400000.gpu: T6034 G15C admitted, ASC=0x0
    
  • Tests: the tests that pinned the J516M as a board without defaults now expect the T6034 defaults for it. Their "no defaults" coverage moves to an unknown T6034 board (apple,j999):
    • test_m3_graphics_defaults.py: J516M gets max14; J516M owner opt-outs for GPU and display; apple,j516m on a T6031 root gets nothing.
    • test_m3_defaults_optout.py: the J514M defaults/owner-choices test is parametrized over J514M and J516M.
    • test_t6034_measurement.py: the J516M is no longer a "bad board"; J516C and an unknown board are.
    • pytest tests/python: 452 passed. test_loadobjs.py fails 2 cases on this machine, the same on Add normal J514M/T6034 graphics handoff #24's unmodified head (tool output format).
    • tests/run-t6030-display.sh passes. run-kboot-gpu-g15.sh (t8122-j613-standin-10) and run-m3-move-gate.sh fail the same way on Add normal J514M/T6034 graphics handoff #24's unmodified head on this machine.
  • Build: a clean make builds, with the same warnings as Add normal J514M/T6034 graphics handoff #24's head (stack usage, Rust dead code) and none new.

Merge Danger

Door: two-way

Blast Radius: J516M only

Only a root with apple,j516m and apple,t6034 on a T6034 chip gets the defaults and the handoff. The J514M and every other Mac are unchanged.

🤖 Generated with Claude Code

The 16" binned M3 Max MacBook Pro (J516M) carries the same T6034 die as
the J514M: its ADT names the same DCP image (F493F03E-...) and the same
G15C GPU firmware layout, and the display handoff registers checked for
the J514M match. Admit apple,j516m wherever the T6034 path is scoped to
the J514M: the m3_max14 default board list, the T6034 DCP handoff
boards, and t6034_board().

Owner choices are unchanged: chosen.asahi,t6034-gpu=0, -dcp=0 and
asahi,m3-defaults=0 opt out as on the J514M, and a lost config drops
the defaults. The tests that pinned the J516M as a board without
defaults now expect the T6034 defaults for it, and keep that coverage
with an unknown T6034 board (apple,j999) instead.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Philip Wallage <philip@btng.studio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant