Repository navigation
kboot: give the J516M the T6034 display and GPU defaults (stacked on #24) - #28
Draft
BTNG-studio wants to merge 1 commit into
Draft
BTNG-studio wants to merge 1 commit into
BTNG-studio wants to merge 1 commit into
Conversation
The 16" binned M3 Max MacBook Pro (J516M) carries the same T6034 die as the J514M: its ADT names the same DCP image (F493F03E-...) and the same G15C GPU firmware layout, and the display handoff registers checked for the J514M match. Admit apple,j516m wherever the T6034 path is scoped to the J514M: the m3_max14 default board list, the T6034 DCP handoff boards, and t6034_board(). Owner choices are unchanged: chosen.asahi,t6034-gpu=0, -dcp=0 and asahi,m3-defaults=0 opt out as on the J514M, and a lost config drops the defaults. The tests that pinned the J516M as a board without defaults now expect the T6034 defaults for it, and keep that coverage with an unknown T6034 board (apple,j999) instead. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Philip Wallage <philip@btng.studio>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give the J516M (16" binned M3 Max) the T6034 display and GPU defaults that #24 gives the J514M. The J516M has the same T6034 die: its ADT names the same DCP image (
F493F03E-…), and the T6034 handoff registers #24 checks match on it.Stacked on #24. It targets #24's branch, so the diff is this one commit.
Owner choices work as on the J514M:
chosen.asahi,t6034-gpu=0,-dcp=0andasahi,m3-defaults=0opt out, and a lost config drops the defaults.Kernel side: omacom/linux-aurora#405 (stacked on omacom/linux-aurora#372). Ship order: this must not ship before that kernel. A J516M with this m1n1 and an older kernel gets the handoff but no board record, and stays on the boot framebuffer.
Evidence
Hardware: my J516M (Mac15,11), iBoot OS firmware 14.7, system firmware 27.0.
9488b7b7, as localm1n1-aurora 1.6.1.aurora22-103(m1n1 stage 2), every boot since 2026-11-06 with the kernel side. Add normal J514M/T6034 graphics handoff #24's head hasn't moved since, so this is the source that booted, plus test updates and one comment's wording.apple,j999):test_m3_graphics_defaults.py: J516M getsmax14; J516M owner opt-outs for GPU and display;apple,j516mon a T6031 root gets nothing.test_m3_defaults_optout.py: the J514M defaults/owner-choices test is parametrized over J514M and J516M.test_t6034_measurement.py: the J516M is no longer a "bad board"; J516C and an unknown board are.pytest tests/python: 452 passed.test_loadobjs.pyfails 2 cases on this machine, the same on Add normal J514M/T6034 graphics handoff #24's unmodified head (tool output format).tests/run-t6030-display.shpasses.run-kboot-gpu-g15.sh(t8122-j613-standin-10) andrun-m3-move-gate.shfail the same way on Add normal J514M/T6034 graphics handoff #24's unmodified head on this machine.makebuilds, with the same warnings as Add normal J514M/T6034 graphics handoff #24's head (stack usage, Rust dead code) and none new.Merge Danger
Door: two-way
Blast Radius: J516M only
Only a root with
apple,j516mandapple,t6034on a T6034 chip gets the defaults and the handoff. The J514M and every other Mac are unchanged.🤖 Generated with Claude Code