Skip to content

kboot: default J514C native display and graphics - #31

Merged
maralcbr merged 5 commits into
integration/aurorafrom
carry/j514c-defaults
Nov 7, 2026
Merged

maralcbr merged 5 commits into
integration/aurorafrom
carry/j514c-defaults

Conversation

@maralcbr

@maralcbr maralcbr commented Nov 7, 2026

Copy link
Copy Markdown
Member

Summary

Carries Chris Kearney's m1n1#23 (J514C native display and graphics defaults), rebased onto integration/aurora after #25, with my sign-off. Chris has left the project. Authorship is kept on his four commits. Replaces #23.

 dt_set_m3_defaults()
   apple,t8122: j613, j615, j504   -> t8122-dcp, -gpu, -gpu-power-standin, -gpu-fuse-leakage
   apple,t6030: j514s, j516s       -> t6030-dcp, -gpu
-  apple,t6031: j516c              -> t6031-dcp, -gpu
+  apple,t6031: j514c, j516c       -> t6031-dcp, -gpu
  • J514C gets the same two independent switches as J516C: chosen.asahi,t6031-gpu=0 or -dcp=0 turns either off, and chosen.asahi,m3-defaults=0 turns off both.
  • Every check behind the switches still runs: board, firmware, identity, reservations and resources.
  • Rebase conflict in tests/python/test_m3_defaults_optout.py: J514C moves out of the "no default" list, and kboot: give the J504 the T8122 display and GPU defaults #25's J433 control is kept.
  • New commit: docs/t8122-gpu-diagnostics.md no longer says the T8122 GPU is off by default with no known image or power model. This was Greptile's finding on kboot: default J514C native display and graphics #23.

Paired kernel change: omacom/linux-aurora#363. Ship order: m1n1 must not ship before that kernel. With an older kernel a J514C gets the handoff but has no board admission, and stays on the boot framebuffer.

Evidence

  • Before (stock): J514C stops at the J516C-only machine check and needs apple_t6031_display.enable=1 and the T6031 lines by hand.
  • After (Scott's lab, m1n1 6560adc with linux-aurora#363 10a834038, j1107-170124-f19e, no enable flags):
    • eDP-1 3024x1964 on apple-drm, asahi-g15 bound.
    • Vulkan compute on G15C B2: 860 dispatches, 0 bad.
  • Rebase: source files merged without conflicts. Only one test file and one doc changed by hand. CI on this branch is the check; the macOS pytest jobs fail on the base too.
  • Audit: no Apple code, firmware bytes or reverse-engineering material in the carried commits.

Merge Danger

Door: two-way

Blast Radius: J514C only

Nothing changes for other boards. An owner can turn it off with chosen.asahi,m3-defaults=0. Power and thermal qualification on J514C is still open, as it is for J516C.

chriskearney and others added 5 commits November 8, 2026 07:19
Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
The candidate build defaults both T6031 display and GPU switches on
J514C. Several comments still say it always requires manual config.
Describe the build-only exception at each handoff and firmware setup
site, retaining owner values and the normal-build behavior.

Cover chosen.asahi,t6031-dcp=0 separately: the explicit display opt-out
survives while the independent GPU switch still defaults on. Format the
new board table without reformatting inherited source.

The two production-body defaults/opt-out suites pass 139 tests, with
eight optional updater integration checks skipped. This revision changes
comments, table whitespace and tests only; the target keeps tested
Stage2 22bd961.

Assisted-by: Codex:GPT-6
Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
Give exact J514C/T6031 boots the same display and GPU defaults as
J516C without a build define or manual boot.bin enable line. Remove
the J514C_BRINGUP switch and update each handoff comment accordingly.
The defaults remain subordinate to explicit owner settings, master-off
and configuration-loss handling; T6034 is unchanged.

Exercise no-config Stage2 boots for both T6031 boards, independent
display/GPU opt-outs and loss handling. The production-body host suites
pass 155 tests, with eight optional updater integration cases skipped.

Assisted-by: Codex:GPT-6
Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
The handoff guide still said J514C needed manual chosen lines despite the normal-build default. Describe both J514C and J516C defaults and owner opt-outs, and align host-test names and comments with the behavior they assert.

Assisted-by: Codex:GPT-6
Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
The T8122 GPU guide still said the GPU setup is off by default and that the
table has no known G15G image, leakage fuse or power model. Normal builds now
set the GPU, display, stand-in power and leakage switches on J613, J615 and
J504, and the kernel starts the GPU on those boards. Describe the defaults,
the owner opt-outs and what remains unmeasured.

Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
@maralcbr
maralcbr requested a review from scottjones as a code owner November 7, 2026 21:21
@greptile-apps

greptile-apps Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge with the stated kernel ship order.

Summary

Adds J514C to the existing T6031 display and GPU defaults.

  • J514C gets the same default display and GPU switches as J516C.
  • The T8122 GPU guide describes the default setup and stand-in power model.

maralcbr explicitly acknowledges that the paired kernel must ship first and that J514C power and thermal qualification remains open. Neither is reported as a new finding.

Reviews (1) · Last reviewed commit: "docs: describe the T8122 GPU defaults an..." · Reviewed by Greptile

@scottjones scottjones left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same commits as #23 plus the test-conflict fix and the T8122 doc fix. #23 passed on the J514C at defaults with no flags (j1107-170124-f19e), and in the combined trial kernel.

@maralcbr
maralcbr merged commit 7f6df96 into integration/aurora Nov 7, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants