Repository navigation
kboot: default J514C native display and graphics - #31
Merged
Merged
Conversation
Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
The candidate build defaults both T6031 display and GPU switches on J514C. Several comments still say it always requires manual config. Describe the build-only exception at each handoff and firmware setup site, retaining owner values and the normal-build behavior. Cover chosen.asahi,t6031-dcp=0 separately: the explicit display opt-out survives while the independent GPU switch still defaults on. Format the new board table without reformatting inherited source. The two production-body defaults/opt-out suites pass 139 tests, with eight optional updater integration checks skipped. This revision changes comments, table whitespace and tests only; the target keeps tested Stage2 22bd961. Assisted-by: Codex:GPT-6 Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
Give exact J514C/T6031 boots the same display and GPU defaults as J516C without a build define or manual boot.bin enable line. Remove the J514C_BRINGUP switch and update each handoff comment accordingly. The defaults remain subordinate to explicit owner settings, master-off and configuration-loss handling; T6034 is unchanged. Exercise no-config Stage2 boots for both T6031 boards, independent display/GPU opt-outs and loss handling. The production-body host suites pass 155 tests, with eight optional updater integration cases skipped. Assisted-by: Codex:GPT-6 Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
The handoff guide still said J514C needed manual chosen lines despite the normal-build default. Describe both J514C and J516C defaults and owner opt-outs, and align host-test names and comments with the behavior they assert. Assisted-by: Codex:GPT-6 Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
The T8122 GPU guide still said the GPU setup is off by default and that the table has no known G15G image, leakage fuse or power model. Normal builds now set the GPU, display, stand-in power and leakage switches on J613, J615 and J504, and the kernel starts the GPU on those boards. Describe the defaults, the owner opt-outs and what remains unmeasured. Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
[Medium impact] The PR appears safe to merge with the stated kernel ship order. SummaryAdds J514C to the existing T6031 display and GPU defaults.
Reviews (1) · Last reviewed commit: "docs: describe the T8122 GPU defaults an..." · Reviewed by Greptile |
This was referenced Nov 7, 2026
scottjones
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carries Chris Kearney's m1n1#23 (J514C native display and graphics defaults), rebased onto
integration/auroraafter #25, with my sign-off. Chris has left the project. Authorship is kept on his four commits. Replaces #23.chosen.asahi,t6031-gpu=0or-dcp=0turns either off, andchosen.asahi,m3-defaults=0turns off both.tests/python/test_m3_defaults_optout.py: J514C moves out of the "no default" list, and kboot: give the J504 the T8122 display and GPU defaults #25's J433 control is kept.docs/t8122-gpu-diagnostics.mdno longer says the T8122 GPU is off by default with no known image or power model. This was Greptile's finding on kboot: default J514C native display and graphics #23.Paired kernel change: omacom/linux-aurora#363. Ship order: m1n1 must not ship before that kernel. With an older kernel a J514C gets the handoff but has no board admission, and stays on the boot framebuffer.
Evidence
apple_t6031_display.enable=1and the T6031 lines by hand.Merge Danger
Door: two-way
Blast Radius: J514C only
Nothing changes for other boards. An owner can turn it off with
chosen.asahi,m3-defaults=0. Power and thermal qualification on J514C is still open, as it is for J516C.