Skip to content

Name the whole Apple top row in the keybindings menu - #105

Open
briantoll wants to merge 1 commit into
omacom:mainfrom
briantoll:brian/key-names-apple-top-row
Open

briantoll wants to merge 1 commit into
omacom:mainfrom
briantoll:brian/key-names-apple-top-row

Conversation

@briantoll

Copy link
Copy Markdown

Name the whole Apple top row in the keybindings menu

Target: omacom/omarchy-mac-pkgs main. Branch brian/key-names-apple-top-row in ~/build/omarchy-upstream/wt-macpkgs (1 commit, re-applied onto the rewritten main from the old-history branch fix/key-names-apple-top-row). Replaces omacom/omarchy-mac#717, which hard-coded the table in the menu script; mainline Omarchy instead reads /usr/share/omarchy-platform/key-names, which this package owns.

Problem

The platform root's key-names tells the keybindings menu that XF86MonBrightnessUp and Down are the F2 and F1 keys, so Shift+F1/F2 shows as the keys you press, but the rest of the built-in keyboard's top row still leaks as raw symbols: rows read XF86AudioMute, XF86AudioRaiseVolume, XF86AudioMicMute and so on, including "SUPER + XF86AudioMute → Screenshot window". The hid-apple table for 2021 and later Apple keyboards maps F1..F12 to brightness, Mission Control, Spotlight, dictation, Do Not Disturb, previous/play/next, mute and volume, and fnmode=1 makes that the bare press.

Fix

Name the full row in omarchy-mac/share/omarchy-platform/key-names: F3 XF86LaunchA, F4 XF86Search, F5 XF86AudioMicMute, F6 XF86Sleep, F7–F9 XF86AudioPrev/Play/Next, F10 XF86AudioMute, F11/F12 XF86AudioLowerVolume/RaiseVolume. The menu matches whole keysyms, so keysyms the built-in keyboard does not have (XF86Calculator, XF86Eject, XF86KbdBrightness*) keep their names. README row updated. No version bump, per #30.

Testing

  • omarchy-mac/test/all: 120 ok, exit 0.
  • test/integration/apple-platform-hooks-test.sh and menu-keybindings-fkeys-test.sh with OMARCHY_TEST_RUNTIME at omacom/omarchy quattro 9305a184f: pass, including the new rows.
  • Live on a MacBook Pro 14" M1 Max against hyprctl binds: "SUPER + XF86AudioMute → Screenshot Window" reads "SUPER + F10", "XF86AudioMicMute → Mute microphone" reads "F5".

🤖 Generated with Claude Code

The platform root's key-names told the keybindings menu that
XF86MonBrightnessUp and Down are the F2 and F1 keys, so Shift+F1/F2 showed
as the keys you press, but the rest of the built-in keyboard's top row still
leaked as raw symbols: rows read XF86AudioMute, XF86AudioRaiseVolume,
XF86AudioMicMute and so on, including "SUPER + XF86AudioMute -> Screenshot
window". The hid-apple table for 2021 and later Apple keyboards maps F1..F12
to brightness, Mission Control, Spotlight, dictation, Do Not Disturb,
previous/play/next, mute and volume, and fnmode=1 makes that the bare press.

Name the full row (F3 XF86LaunchA, F4 XF86Search, F5 XF86AudioMicMute, F6
XF86Sleep, F7-F9 XF86AudioPrev/Play/Next, F10 XF86AudioMute, F11/F12
XF86AudioLowerVolume/RaiseVolume). The menu matches whole keysyms, so
nothing else is touched; keysyms the built-in keyboard does not have
(XF86Calculator, XF86Eject, XF86KbdBrightness*) keep their names.

Verified on a MacBook Pro 14" M1 Max against the live binds: "SUPER +
XF86AudioMute -> Screenshot Window" now reads "SUPER + F10", and
"XF86AudioMicMute -> Mute microphone" reads "F5". The integration tests
cover the new names against the runtime. No version bump, per omacom#30.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Expands the Apple keyboard names shown in the keybindings menu from F1–F2 to F1–F12.

  • Apple keybindings now show the whole top row as F1 through F12.

Reviews (1) · Last reviewed commit: "Name the whole Apple top row in the keyb..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant