Repository navigation
Conversation
The platform root's key-names told the keybindings menu that XF86MonBrightnessUp and Down are the F2 and F1 keys, so Shift+F1/F2 showed as the keys you press, but the rest of the built-in keyboard's top row still leaked as raw symbols: rows read XF86AudioMute, XF86AudioRaiseVolume, XF86AudioMicMute and so on, including "SUPER + XF86AudioMute -> Screenshot window". The hid-apple table for 2021 and later Apple keyboards maps F1..F12 to brightness, Mission Control, Spotlight, dictation, Do Not Disturb, previous/play/next, mute and volume, and fnmode=1 makes that the bare press. Name the full row (F3 XF86LaunchA, F4 XF86Search, F5 XF86AudioMicMute, F6 XF86Sleep, F7-F9 XF86AudioPrev/Play/Next, F10 XF86AudioMute, F11/F12 XF86AudioLowerVolume/RaiseVolume). The menu matches whole keysyms, so nothing else is touched; keysyms the built-in keyboard does not have (XF86Calculator, XF86Eject, XF86KbdBrightness*) keep their names. Verified on a MacBook Pro 14" M1 Max against the live binds: "SUPER + XF86AudioMute -> Screenshot Window" now reads "SUPER + F10", and "XF86AudioMicMute -> Mute microphone" reads "F5". The integration tests cover the new names against the runtime. No version bump, per omacom#30. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
[Low impact] The PR appears safe to merge. SummaryExpands the Apple keyboard names shown in the keybindings menu from F1–F2 to F1–F12.
Reviews (1) · Last reviewed commit: "Name the whole Apple top row in the keyb..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name the whole Apple top row in the keybindings menu
Target: omacom/omarchy-mac-pkgs
main. Branchbrian/key-names-apple-top-rowin~/build/omarchy-upstream/wt-macpkgs(1 commit, re-applied onto the rewrittenmainfrom the old-history branchfix/key-names-apple-top-row). Replaces omacom/omarchy-mac#717, which hard-coded the table in the menu script; mainline Omarchy instead reads/usr/share/omarchy-platform/key-names, which this package owns.Problem
The platform root's
key-namestells the keybindings menu thatXF86MonBrightnessUpandDownare the F2 and F1 keys, so Shift+F1/F2 shows as the keys you press, but the rest of the built-in keyboard's top row still leaks as raw symbols: rows readXF86AudioMute,XF86AudioRaiseVolume,XF86AudioMicMuteand so on, including "SUPER + XF86AudioMute → Screenshot window". The hid-apple table for 2021 and later Apple keyboards maps F1..F12 to brightness, Mission Control, Spotlight, dictation, Do Not Disturb, previous/play/next, mute and volume, andfnmode=1makes that the bare press.Fix
Name the full row in
omarchy-mac/share/omarchy-platform/key-names: F3XF86LaunchA, F4XF86Search, F5XF86AudioMicMute, F6XF86Sleep, F7–F9XF86AudioPrev/Play/Next, F10XF86AudioMute, F11/F12XF86AudioLowerVolume/RaiseVolume. The menu matches whole keysyms, so keysyms the built-in keyboard does not have (XF86Calculator,XF86Eject,XF86KbdBrightness*) keep their names. README row updated. No version bump, per #30.Testing
omarchy-mac/test/all: 120 ok, exit 0.test/integration/apple-platform-hooks-test.shandmenu-keybindings-fkeys-test.shwithOMARCHY_TEST_RUNTIMEat omacom/omarchyquattro9305a184f: pass, including the new rows.hyprctl binds: "SUPER + XF86AudioMute → Screenshot Window" reads "SUPER + F10", "XF86AudioMicMute → Mute microphone" reads "F5".🤖 Generated with Claude Code