Repository navigation
Conversation
…missing tools/release/test/omacom-lane skips the check that omarchy-mac-pkgs commits hash to the checksums makepkg recorded in omacom/omarchy-pkgs when the checkout lacks those commits, and prints ok. omacom#113 made CI check out the full history, but a later shallow checkout would hide the check again. With CI=true the missing history is now a failure that names the cause; a local shallow clone still skips. The tooling suites step passes CI into the Arch container, since docker exec does not carry the runner's environment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tools/release/test/omacom-lanechecks that four omarchy-mac-pkgs commits hash to the checksums makepkg recorded for them in omacom/omarchy-pkgs. When the checkout lacks those commits, it printsok - # skip: ...and passes. #113 made CI check out the full history, so the check runs there now. But nothing stops a later workflow edit from making that checkout shallow again. The check would then skip, CI would stay green, and a change that broke how releases compute a git source's checksum could merge. AGENTS.md: "a skipped test, or a job that failed before reaching the tests, is not a pass."Change
tools/release/test/omacom-lane: whenCIistrueand the history is missing, the check fails and names the cause. A local shallow clone still skips, as before..github/workflows/tests.yml: the Tooling suites step passes-e CItodocker exec, so the test inside the Arch container sees the runner'sCI=true.$tmp/outis cleared, so a failure here no longer prints the earlier hashing test's output under it.Tests and CI only, so
omarchy-mac/versionstays as it is.Verification
Setup. x86_64 Linux (Ubuntu 26.04), a depth-1 clone of each commit. An AI agent ran every check, each local run twice with the same output; no person tested this change.
Steps.
CI=true bash tools/release/test/omacom-lane→ read the exit status.Before, main
28abebe: the check skips, exit 0:After,
7d26b31: the check fails and names the missing history, exit 1:Without
CIit still skips; a full clone withCI=truepasses (details).ok - omarchy-mac-pkgs commits hash to the checksums makepkg recorded in omarchy-pkgs.Links. Commits
28abebe(main) and7d26b31; the regression test; #113.Not shown
CIreaches the container. That rests on howdocker exec -e NAMEworks: the docker CLI fills in a bare name from its own environment.tools/acceptance/test/mac-image-run-test.shandasahi-fresh-run-test.shwere not run locally withCIset. Nothing in this repository reads it apart fromomacom-lane.Prior PRs
Follows #113 (above).
Unedited runs and detail
Terminal captures, as first posted:
Full run on main:
Full runs on this branch:
CI=false: exit 0, skip line.CI=true: exit 1, with no leftover output under it.CI=true bash tools/release/test/candidate-setandactionlint .github/workflows/tests.yml: exit 0.not ok - the checksum of omarchy-mac-pkgs 5b2c815f007d is not the 00000000e396 makepkg recorded.docker execpasses only the variables it is given, so without-e CIthe test never sees the runner'sCI=true. A bare-e CItakes the runner's value.CI, so passing it to the other three tooling suites changes nothing for them. Only the suites job runsomacom-lane, and its omarchy-mac-pkgs checkout already hasfetch-depth: 0, so this change leaves CI green.Generated with Claude Opus 5.5 in T3 Code Nightly