Repository navigation
Name Touch ID as a fingerprint reader - #43
Closed
RyanTheTide wants to merge 1 commit into
Closed
RyanTheTide wants to merge 1 commit into
RyanTheTide wants to merge 1 commit into
Conversation
omarchy-hw-fingerprint recognises a reader the kernel drives without USB only through /usr/share/omarchy-platform/fingerprint-readers, and no package shipped one, so Omarchy's fingerprint setup said "No fingerprint sensor detected" on a Mac with Touch ID. Ship the file with the Secure Enclave driver's diag/touchid, which reads "ready" once the sensor is bound and its fingerprints are restored. The line is the one in Scott Jones's omacom#12, which carries the rest of the Touch ID integration. Test against the runtime merge of omacom/omarchy#14675, which reads the file, and give the factory-reset test that runtime's omarchy-i18n (both from omacom#12). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Closing this in favour of #12. It's a byte-identical subset of #12, and on its own it would do harm: Omarchy would show the one-time fingerprint invitation as soon as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
omarchy-hw-fingerprint(omacom/omarchy#14675) can only recognise a reader that the kernel drives without USB through/usr/share/omarchy-platform/fingerprint-readers. No package ships that file, so on a Mac with Touch ID, Omarchy's fingerprint setup says "No fingerprint sensor detected".Change
omarchy-macships the file with one entry:In linux-aurora (
drivers/soc/apple/diag_shim.cat omacom/linux-aurora 44d5afc79da7),diag/touchidreadsreadyonly after Touch ID has started and the sensor is online. It readsnot-ready,failedorunknownotherwise. A Mac that has not brought Touch ID up therefore still gets no invitation, and a USB reader is still found.Overlap with #12 (@scottjones): this is the reader-list part of #12 on its own. The line, the desktop-setup assertion,
fingerprint-readers-test.sh, the runtime pin (81fd2d23, the merge of omacom/omarchy#14675) and theomarchy-i18nfix to the factory-reset test are byte-identical to #12, so either PR rebases cleanly over the other. This PR leaves out #12's activation unit, udev rule, alpm hook, fprintd drop-in, sleep hook and version bump. #12's README says to ship this file only once a stock boot enrols. That gate holds here because the file only matches once the owner has brought Touch ID toready. Whether that is enough, given that calibration can be missing even while the sensor reads ready, is your call, Scott.Tests
The CI workflow's Arch container steps, run on the buildbox against runtime 81fd2d23:
test/integration/fingerprint-readers-test.shpasses (2/2): Touch ID is found only once it readsready, and a not-ready Touch ID leaves a USB reader to be found.omarchy-mac/test/desktop-setup-test.shpasses, sofingerprint-readersis staged in the platform root with the exact line.mainagainst the same runtime.mpv,factory-reset-luks,mac-update-boot-verify,snapshot-restore-macandprovision-owner-luks(which hangs) fail identically on unmodifiedmainin that container.🤖 Generated with Claude Code