Skip to content

Describe the replaced mpv default without naming a release - #57

Merged
scottjones merged 1 commit into
mainfrom
docs/mpv-version-agnostic
Oct 24, 2026
Merged

scottjones merged 1 commit into
mainfrom
docs/mpv-version-agnostic

Conversation

@maralcbr

Copy link
Copy Markdown
Member

Summary

Follow-up to omarchy-mac-pkgs#32. The docs and comments described the replaced mpv default by release ("0.2.2 or earlier", "installed before 0.2.3"). That wording already went stale once as main's version moved. The hash gate matches the earlier default whatever release shipped it, so the text now says that.

- byte-identical to the copy omarchy-mac 0.2.2 and earlier made, which lacks `gpu-sw=yes`
+ byte-identical to the earlier default, which lacks `gpu-sw=yes`
- on a Mac installed before 0.2.3 run `sudo omarchy-mac-setup-system`
+ on a Mac that already had the earlier default, run `sudo omarchy-mac-setup-system`

Touched: omarchy-mac/README.md:15, :44, mac-manual/content/12-hardware.md:46, the mpv.conf header (rewrapped), the omarchy-mac-setup-system:54 comment. No code change, so no version bump. Test names in mpv-test.sh still name the 0.2.2 fixture; that's accurate for the fixture, so they're unchanged.

Evidence

  • omarchy-mac/test/mpv-test.sh: 5 ok, run in CI's Arch image.
  • shellcheck omarchy-mac/bin/omarchy-mac-setup-system: clean.
  • No 0.2.2/0.2.3 left in the mpv text: grep -n '0\.2\.[23]' over the four files matches only README line 3's version.

Merge Danger

Door: two-way

Blast Radius: docs

The shipped mpv.conf changes only in comments. A fresh install copies the new text; an existing /etc/mpv/mpv.conf from 0.2.3 is kept, as tmpfiles never overwrites it, and setup's hash gate doesn't match it. If a later migration ever gates on the shipped default again, it has two current-default hashes to know about.

PR 32's wording named 0.2.2 and 0.2.3, which went stale once before as
main's version moved. The hash gate matches the earlier default whatever
release shipped it, so the docs and comments now say that instead.
@maralcbr
maralcbr requested a review from scottjones as a code owner October 24, 2026 01:49
@greptile-apps

greptile-apps Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Replaces release-specific descriptions of the earlier mpv default with wording tied to its contents.

  • The mpv migration guidance names the earlier default, not a package release.

Reviews (1) · Last reviewed commit: "Describe the replaced mpv default withou..." · Reviewed by Greptile

@scottjones scottjones left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We checked the new wording against the setup code: it still replaces only an unedited regular file matching the old hash, leaves edited copies and links alone, and still says an upgrade alone does not apply it. Main has only ever shipped one mpv default without gpu-sw, so "the earlier default" is precise, and tying the text to its contents avoids it going stale again. Both mpv-test.sh and the full omarchy-mac suite pass, and since only comments change, no version bump is needed.

@scottjones
scottjones merged commit 914fd71 into main Oct 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants