Repository navigation
Describe the replaced mpv default without naming a release - #57
Conversation
PR 32's wording named 0.2.2 and 0.2.3, which went stale once before as main's version moved. The hash gate matches the earlier default whatever release shipped it, so the docs and comments now say that instead.
[Low impact] This PR appears safe to merge. SummaryReplaces release-specific descriptions of the earlier mpv default with wording tied to its contents.
Reviews (1) · Last reviewed commit: "Describe the replaced mpv default withou..." · Reviewed by Greptile |
scottjones
left a comment
There was a problem hiding this comment.
We checked the new wording against the setup code: it still replaces only an unedited regular file matching the old hash, leaves edited copies and links alone, and still says an upgrade alone does not apply it. Main has only ever shipped one mpv default without gpu-sw, so "the earlier default" is precise, and tying the text to its contents avoids it going stale again. Both mpv-test.sh and the full omarchy-mac suite pass, and since only comments change, no version bump is needed.
Summary
Follow-up to omarchy-mac-pkgs#32. The docs and comments described the replaced mpv default by release ("0.2.2 or earlier", "installed before 0.2.3"). That wording already went stale once as main's version moved. The hash gate matches the earlier default whatever release shipped it, so the text now says that.
Touched:
omarchy-mac/README.md:15,:44,mac-manual/content/12-hardware.md:46, thempv.confheader (rewrapped), theomarchy-mac-setup-system:54comment. No code change, so no version bump. Test names inmpv-test.shstill name the 0.2.2 fixture; that's accurate for the fixture, so they're unchanged.Evidence
omarchy-mac/test/mpv-test.sh: 5 ok, run in CI's Arch image.shellcheck omarchy-mac/bin/omarchy-mac-setup-system: clean.0.2.2/0.2.3left in the mpv text:grep -n '0\.2\.[23]'over the four files matches only README line 3's version.Merge Danger
Door: two-way
Blast Radius: docs
The shipped
mpv.confchanges only in comments. A fresh install copies the new text; an existing/etc/mpv/mpv.conffrom 0.2.3 is kept, as tmpfiles never overwrites it, and setup's hash gate doesn't match it. If a later migration ever gates on the shipped default again, it has two current-default hashes to know about.