Repository navigation
Conversation
On M1, M1 Pro and M1 Max Macs the built-in microphones sit on the Secure Enclave's data path: until the enclave boots, every capture is about 40 ms of filter transient followed by exact zeros, and dictation reports no speech. The installed linux-aurora (7.2.11.aurora14-1) builds the driver as a module (CONFIG_APPLE_SEP=m) and the J313 device tree enables the sep@242400000 node, but the module exports no alias, so nothing loads it on a normal boot (omacom/linux-aurora#141; #180 restores the alias and boots the enclave without the xART store, which makes this unit redundant once it ships). The package's Touch ID load only runs on the owner's record, and touchid-eligibility reports unsupported:m1-family on these Macs, so that path is closed to them. omarchy-mac-sep-load.service, pulled in by the package's multi-user.target wants link, runs after local-fs.target and the Touch ID status and before the display manager, so the session's first capture already works. Its condition, lib/sep-for-microphone, reads only the device tree: an apple,t8103, apple,t6000 or apple,t6001 root whose soc/sep@* node is enabled. Later Macs record without the enclave and never load it here, and a Mac whose owner turned Touch ID on leaves the driver to the Touch ID load, which owns its options. As that load, the unit waits for the iBoot System Container's partition link, which the driver opens as it probes without retrying, inside the service rather than as a device dependency. The load is read-only: modprobe apple-sep xart_writes=0 provision_keybag=0 boots the enclave, never writes the anti-replay store shared with macOS and makes no keybag, and Touch ID stays off since its activation needs the owner's record. Confirmed on a MacBook Air M1 (J313, t8103, macOS 13.5 firmware): the kernel logged the xART writes as disabled, TZ0 accepted and IMG4 acknowledged, and the microphone delivered live audio at about -42 dBFS; Superwhisper then transcribed speech. The read-only driver leaves Linux-only state in /var/lib/aurora-sep-host-state.bin. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge; no actionable defect was established. SummaryAdds a read-only Secure Enclave boot service for M1-family microphones.
No actionable issues were established. Tests were inspected, not run during this review.
|
scottjones
left a comment
There was a problem hiding this comment.
Thanks for tracking this down, Naeem. The diagnosis matches what we see in the kernel tree, and loading the driver read-only is exactly the right shape for a workaround until omacom/linux-aurora#180 lands. We found no code defect that blocks this.
The one real ask: before this ships to every M1 in 4.5, we'd like one real boot on M1 hardware. Nothing loaded this driver on M1 by default until now. With this PR, every M1 owner starts running its suspend notifier, hwrng and shutdown paths at every boot, and so far it has only been loaded by hand.
Hardware check
- Reboot with the unit installed: the unit succeeds
-
journalctl -k -bshowsIMG4 acknowledged - Note whether
xART: refused the enclave's writeappears - Mic works
- Lid-close suspend and resume: mic works after resume, overnight drain looks normal
- Clean reboot and shutdown
- Boot macOS afterwards: Touch ID unlock and FileVault login still work
The driver's read-only guarantee covers what Linux writes. Whether the enclave itself wants to write during a plain boot, and what it does when refused, can only be seen on hardware. A boot with xarm_trace=1 would show it.
Smaller points
-
When this unit's
modprobeis the first load and anapple_sepxart_writes=orprovision_keybag=option is already set elsewhere, the load fails withEEXIST, even when the other setting is also 0. If the driver is already loaded, a plainmodprobeexits 0 and ignores the options. So on a linux-aurora#180 kernel (udev loads first), or with aurora-sep's own loader (orderedBefore=systemd-udevd), this is at most a red unit and the mics still work. The mics stay dead only when nothing else loads the driver:- a hand-written or orphaned
options apple_sep xart_writes=…/provision_keybag=…conf, which aurora-sep's README tells owners to set apple_sep.xart_writes=on the kernel command line, which kmod passes to modprobe and which the omarchy-mac README describes as an override
It fails safe, but the owner gets a failed unit and no mic. Could the unit skip when
modprobe -cor/proc/cmdlinealready setsapple_sepoptions, and leave the load to whoever configured it? - a hand-written or orphaned
-
modprobereturns as soon as TZ0 is sent, so a handoff that fails later (for example, no SEP firmware region from m1n1) leaves the unit green and the mic silent. No check needed in this PR, but worth knowing when triaging "mic dead on M1" reports. -
Two test gaps, both found by mutation. Everything else we broke failed the test.
- Dropping
omarchy-mac-touchid-status.servicefromAfter=(omarchy-mac-sep-load.service:13) still passes. - Adding
apple,t8140to the gate (lib/sep-for-microphone:13) still passes. The Neo is the one later Mac whose tree enables the SEP node, so it's the negative case most worth a fixture.
- Dropping
-
The driver says it is "deliberately not exported as a module alias ... only after the owner has enabled it (or chosen read-only)" (
sep.rs, aboveOF_TABLE). This unit loads it on every M1 with no choice offered. linux-aurora#180 makes the same call in the kernel, so the two agree, but the manual should say how to opt out (systemctl mask omarchy-mac-sep-load.service). Could you also open an issue to remove the unit once linux-aurora#180 ships? Nothing here removes it automatically.
What we checked and agree with
We read the unit and helper against the driver on linux-aurora integration/aurora (396f2d63edc).
- Read-only holds at the block layer, not just by policy. With
xart_writes=0the driver opens the iBoot System ContainerO_RDONLY(store_shim.c,sep_store_open_block), the store never arms repair, andStore::write()/delete()returnEROFS(xart_store.rs:120-200,:346,:402).provision_keybag=0skips keybag creation. The driver writes only Linux-side files under/var/lib(host-state, xart-owned, keybag, refkey, catacomb), and the "already booted" marker is an in-memory DT property. This is a really nice design. - The options can't be quietly overridden. Rust module params are
SetOnce(rust/kernel/module_param.rs:78-83). modprobe puts config options before command-line ones (modprobe -Dshows... xart_writes=1 provision_keybag=1 xart_writes=0 provision_keybag=0), so a conflictingoptions apple_sep xart_writes=1makes the second set returnEEXISTandload_modulerefuses to load. It never ends up loaded with writes on. - Every Omarchy-era kernel has both params (we checked the tags from
aurora-2026.10.09on), so a snapshot boot onto an older kernel still gets them. Kernels from before the params existed had no xART store code. - The gate is exact and fails closed. Only
j293,j313,j456/j457and the fourt6000/t6001MacBook Pros enable&sep. The Mac mini (j274) and the M1 Max Mac Studio (j375c, at6001) leave it disabled, the M1 Ultra Studio (j375d,t6002) is outside the compatible list, and on everyt600xthe node sits at/soc/sep@396400000. On M2 and M3 the node is disabled in the tree, and the Neo is enabled but outside the compatible list. Every error path (missing predicate, unreadable tree, no node, missing helper) exits 1 or 203, which systemd treats as a skip. - On M1, Touch ID eligibility reports
unsupported:m1-family, sotouchid-oncan't be created there and the Touch ID load and this unit don't overlap.touchid-enablealready handles a driver someone else loaded (preloaded=1). - The wants link sits in
/usr/lib, so an upgrade needs no enable or migration step and an uninstall removes it. It takes effect at the next boot.
What we ran: omarchy-mac/test/all (119 ok), sep-microphone-test.sh alone, .github/scripts/check-scope and check-architecture-gates. All pass, and CI is green including Shellcheck. We mutated the gate, status check, platform check, final exit, read-only options, Touch ID condition, wants link and greeter ordering, and each one failed the test. We haven't run it on hardware.
|
I applied this on a clean new Omarchy 4.5 install on a M1 Macbook Air and can confirm the PR works and survives warm and cold reboots. |
|
Same symptom here on a second MacBook Air M1, on a recent install (2026-11-05). The manual load in this PR fixed it. System
Observed
Ruled out
Manual load of After |
maralcbr
left a comment
There was a problem hiding this comment.
Reviewed at 7510ab6.
Thanks Naeem, and thanks to the two testers who confirmed it on M1 Airs. The read-only load is the right workaround until omacom/linux-aurora#180 lands, and I found nothing that writes the shared xART store. A few things need to change before merge, though.
Before merge
- Conflicts. main is at 0.2.6. Resolve
omarchy-mac/versionandomarchy-mac/README.mdand bump to 0.2.7. - The fprintd gate this repo already asks for. The Touch ID load bullet in
omarchy-mac/README.mdsays fprintd still opens/dev/sep-biowhen it probes its readers, so a kernel that loads the driver on every Mac needs fprintd's allowance for the node gated first. This PR is that kind of load on every M1.omarchy-mac-touchid-activate.serviceis gated on the owner's record, but fprintd isn't. On an M1 with fprintd installed (a USB reader, say), probing the readers opens the node, and an open is activation (lib/touchid-activate:44-46). Withxart_writes=0 provision_keybag=0that shouldn't write anything shared. It still crosses the consent boundary the package draws. Either gate fprintd's allowance on/etc/omarchy-mac/touchid-on, or show that the shipped libfprint never openssep-bioon these Macs. - Scott's EEXIST point. If
apple_sepxart_writes=/provision_keybag=is already set in modprobe.d or on the cmdline and this is the first load, the unit fails and the mic stays dead. Skipping the unit when options are set elsewhere only avoids the red unit, so handle both cases: configured elsewhere and loaded by someone else, versus configured but nothing else loads it. Please add tests for duplicate zero, conflicting and already-loaded. - Docs that become false on M1:
omarchy-mac/README.mdfingerprint-readers bullet: "Nothing loads the Secure Enclave driver until the owner agrees", and that disable-fingerprint makes the driver stop loading.mac-manual/content/04-security.md: "Turning Touch ID off later … stops the driver loading."- Please also document the opt-out,
systemctl mask omarchy-mac-sep-load.service.
Behaviour change, accepted explicitly. This boots the enclave shared with macOS on every M1 at every boot without asking the owner. The driver's own OF_TABLE comment reserves that for an owner choice. Default-on with a documented mask is defensible to get the built-in mics working, and I'm fine with it. I'm saying it here so it's an explicit decision and not a side effect of a bug fix.
Before release (not blocking merge to edge): Scott's checklist on a real installed boot. Lid suspend and resume with the mic, overnight drain, clean shutdown, and macOS Touch ID and FileVault afterwards are still unreported. Please include journalctl -k -b for IMG4 acknowledged and any xART: refused the enclave's write. Please also send systemd-analyze blame and critical-chain display-manager.service, since the unit sits in front of the greeter with a 20 s wait plus the SEP handshake.
Nice to have
- One t6000/t6001 confirmation that the mic is dead without the enclave and works with it. Only t8103 has been tested so far.
- Scott's two test gaps: drop
omarchy-mac-touchid-status.servicefromAfter=, and addapple,t8140as a negative fixture. - An issue to remove the unit once linux-aurora#180 ships.
The driver's parameters can be set once, so passing xart_writes or provision_keybag after the same option in modprobe.d or on the kernel command line fails the load with EEXIST, and the microphone stays silent when nothing else loads the driver. lib/sep-load counts what modprobe -c and /proc/cmdline set, passes only the missing write options as 0, uses options already at 0, and leaves a loaded driver or any write option other than 0 to whoever set it. An option set twice fails the unit with a message. Writes are never enabled.
…ps the MacBook Neo Dropping omarchy-mac-touchid-status.service from After= and adding apple,t8140 to the gate both passed the suite; each now fails it.
Every helper under lib stops off Apple Silicon on its own; the platform test caught sep-load without it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Thanks both. I went through the review points that don't need the M1. Pushed to this branch as a merge of main (no rebase), so the history stays as reviewed. Marcelo's list:
Scott's two test gaps: a test now fails if Not done yet: the real boot checklist, the I ran each test script on its own: all pass except setup-test and desktop-setup-test, which can't write to $HOME where I ran them (main fails the same way there), so CI is the check for those two. check-scope and check-architecture-gates pass. |
maralcbr
left a comment
There was a problem hiding this comment.
@malik-na, thanks, this round at ed7c3ce closes most of my list. The merge and 0.2.7 bump are in. lib/sep-load handles options set elsewhere without ever passing anything but 0. The docs no longer say nothing loads the driver, the mask is documented, and Scott's two test gaps now fail the suite.
Still needed before merge:
- fprintd can still open
/dev/sep-bioon these Macs. You've confirmed libfprint's probe opens it read-write, and I agree the gate can't be done from this package, since the allowance is inlibfprint-git's drop-in. Whether the read-only load creates the node still needs the M1, as you say, so this is conditional on the node existing. It still needs one of two things: an omacom/omarchy-pkgs change that gates the allowance on/etc/omarchy-mac/touchid-onand lands first, or an explicit decision from Marcelo to accept it until then, withREADME.md:29saying so. Only M1 owners who installed fprintd are exposed. Please don't order fprintd after this unit in the meantime, since that would only make the access more reliable. - The kernel command line is counted twice (
lib/sep-load:25-29). kmod already parsesapple_sep.*words from/proc/cmdlineinto the optionsmodprobe -cprints. Reading/proc/cmdlineas well counts a singleapple_sep.provision_keybag=0twice, so the unit fails at:44-46and the mic stays silent. The test'smodprobe -cstub prints only the config, so it can't show this. Please drop the/proc/cmdlineloop and keep the duplicate check for real duplicates. Please also have the stub print command-line options as kmod does, with two fixtures: an option only on the command line (loads) and the same option in both places (fails).
Smaller things:
- A quoted zero skips the load (
sep-load:37). The kernel strips the quotes fromxart_writes="0", so it's a valid zero. The helper treats it as writes enabled, though, and the mic stays silent behind a green unit. It fails safe. Please strip the quotes before comparing, add a fixture, and log that the built-in microphones stay silent whenever it does skip. - Hyphenated names are missed (
sep-load:30). The kernel treatsxart-writesandxart_writesas the same parameter, but the filter only knows the underscore form. Withoptions apple_sep xart-writes=0, the helper also appendsxart_writes=0, the duplicate refuses the load, and the mic stays silent. Please normalise-to_in parameter names before filtering and counting, with fixtures. README.md:29still says the module "loads only on the owner's record". Suggest adding "or, on M1-family Macs, through the read-only microphone load".
Nits, fine as follow-ups: the unit's header is eight lines and sep-load's is four, where AGENTS.md:34 asks for three. Please write omacom/linux-aurora#180 in omarchy-mac-sep-load.service:4 and README.md:30, since a bare #180 reads as this repo's.
CI: every check passes, including the package suite. It stubs modprobe, though, so it doesn't cover point 2, and the systemd-analyze blocks only run where the runner has it.
For release, not the merge: this is boot-critical, so it still needs a real installed boot on an M1 (CONTRIBUTING). That means Scott's checklist and the journalctl -k -b, systemd-analyze blame and critical-chain display-manager.service output. A t6000 or t6001 confirmation would still be good to have.
Reviewed at ed7c3ce1ba41.
— Marcelo's agent
kmod folds the apple_sep.* words of /proc/cmdline into the options that modprobe -c prints (libkmod-config.c, kmod_config_parse_kcmdline), so reading /proc/cmdline as well counted one setting twice and failed the load with a false duplicate. The modprobe stub in the test now prints command-line options the way kmod does: after the files, one options line per word. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The kernel reads xart-writes and xart_writes as one parameter. With options apple_sep xart-writes=0 the filter missed the setting, sep-load added xart_writes=0 and the second setting refused the load with EEXIST. Names are normalised before filtering and counting. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…tay silent The kernel strips the quotes of xart_writes="0", so it is a valid zero, but the helper read it as writes enabled and skipped the load. Quotes are stripped before comparing. Whenever the helper leaves the load to someone else or fails on a duplicate, it now logs that the built-in microphones stay silent. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
README line 29 now says the module also loads through the read-only microphone load on M1-family Macs. The unit and sep-load headers are three lines, as AGENTS.md asks. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Thanks for the second pass, Marcelo. I pushed a round that covers everything except the fprintd gate.
I ran the omarchy-mac suite and the scope and architecture-gate checks, and broke each new fixture's code to see its test fail. In my sandbox Still open:
|
maralcbr
left a comment
There was a problem hiding this comment.
@malik-na re-reviewed at 77a58f6: all the code points from my last round are fixed.
lib/sep-loadnow reads onlymodprobe -c(sep-load:17-25), so a command-line option is counted once. The stub prints command-line words the way kmod does, with fixtures for an option only on the command line and one in both places (sep-microphone-test.sh:121-124).- Quotes are stripped and hyphens normalised before counting (
sep-load:18,:22), with fixtures for each. - A skipped or failed load now says the built-in microphones stay silent (
:33,:40), and the test checks it. README.md:29names the read-only microphone load, omacom/linux-aurora#180 is written in full, and both headers are three lines.
The helper still only ever passes 0 (sep-load:43), and it leaves any other write setting to whoever set it. I found no code blockers.
Still open before merge, and not a code issue:
- fprintd can open
/dev/sep-bioon M1 Macs with fprintd installed. The activation unit waits for the owner's record (omarchy-mac-touchid-activate.service:8), but the fprintd drop-in only orders fprintd (fprintd.service.d/50-omarchy-mac-touchid.conf:5-6). This needs a decision from Marcelo. One option is an omacom/omarchy-pkgs change that gateslibfprint-git's allowance on/etc/omarchy-mac/touchid-onand lands first. The other is accepting the exposure until then, noted inREADME.md:29. Thanks for not ordering fprintd after this unit in the meantime.
Nit, fine as a follow-up: AGENTS.md:33 prefers a full if/else to an exit in one branch (sep-load:10-13, :32-35, :39-41).
CI: every check passes, including the package suite, which runs sep-microphone-test.sh. modprobe is stubbed there, so kmod's real modprobe -c output is only covered by a hardware boot.
For release, not the merge: this is boot-critical, so it still needs cold-boot evidence from an installed M1 (CONTRIBUTING.md:54). That means Scott's checklist plus the journalctl -k -b, systemd-analyze blame and critical-chain display-manager.service output. The earlier tester reports came before sep-load. A t6000 or t6001 confirmation would still be good to have.
Reviewed at 77a58f66cdbe.
— Marcelo's agent
…anches The helper keeps the same behaviour: a driver already loaded is left alone, a write option enabled elsewhere leaves the load to its owner, an option set twice fails with the EEXIST message, and only the options still unset are passed as 0, in option order as before. Each outcome is now a branch of one if/else chain at the end, as AGENTS.md prefers, rather than an exit inside the loops. Nothing passes anything but 0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
maralcbr
left a comment
There was a problem hiding this comment.
@malik-na re-reviewed at ba0736d. The if/else rewrite of lib/sep-load keeps every outcome the same, and it fixes the nit from my last round.
- A loaded driver is still left alone (
sep-load:10-11). - A non-zero setting still leaves the load to its owner, with exit 0 (
:33-35,:50-51). As before, it wins over a duplicate of the same option. - A duplicate still fails with the EEXIST message and exit 1 (
:42-44,:52-54), andxart_writesis still settled beforeprovision_keybag. - Only unset options are passed, and only as
0(:45-46,:56).
The existing fixtures cover each of those branches (sep-microphone-test.sh:115-154). I found no code blockers.
Still open before merge, and not a code issue:
- fprintd can open
/dev/sep-bioon M1 Macs with fprintd installed. Nothing has changed here since my last round. The activation unit waits for the owner's record (omarchy-mac-touchid-activate.service:8), but the fprintd drop-in only orders fprintd (fprintd.service.d/50-omarchy-mac-touchid.conf:5-6), and an open is activation (lib/touchid-activate:44-46). This needs a decision from Marcelo. One option is an omacom/omarchy-pkgs change that gateslibfprint-git's allowance on/etc/omarchy-mac/touchid-onand lands first. The other is accepting the exposure until then, noted inREADME.md:29.
CI: every check listed passes, including the package suite, which runs sep-microphone-test.sh. The list doesn't name a commit, though, so it's worth confirming the runs are at ba0736d. modprobe is stubbed in the suite, so kmod's real modprobe -c output is only covered by a hardware boot.
For release, not the merge: this is boot-critical, so it still needs cold-boot evidence from an installed M1 (CONTRIBUTING.md:54). That means Scott's checklist plus the journalctl -k -b, systemd-analyze blame and critical-chain display-manager.service output. The tester reports from 2026-11-07 came before sep-load. A t6000 or t6001 confirmation would still be good to have.
Reviewed at ba0736d41a73.
— Marcelo's agent
maralcbr
left a comment
There was a problem hiding this comment.
Reviewed at ba0736d.
Thanks Naeem, this round closes nearly everything. The conflicts and the 0.2.7 bump are in, lib/sep-load handles the ordinary EEXIST cases, the docs and the mask opt-out are in, and Scott's two test gaps now fail the suite. CI is green at this head. Two things are left before merge.
1. sep-load can still load with writes on (lib/sep-load:15-23, :56). kmod passes modprobe.d options before the ones on the modprobe command line, and the kernel stops parsing at --. It warns but still loads the module (kernel/params.c:183, kernel/module/main.c:3585). So with options apple_sep --, the appended xart_writes=0 provision_keybag=0 are ignored, and a pre-linux-aurora#180 kernel loads with its write defaults. Quoted whitespace gets around it too. With options apple_sep foo="a provision_keybag=0", the helper's whitespace split sees provision_keybag=0 and doesn't append it, but the kernel sees one unknown foo parameter, so the keybag default applies. Both configs are contrived, but "never enables a write" is the guarantee this unit rests on. Please parse fail-closed: skip the load, with the microphone message, on any apple_sep option token that isn't a plain name=value (--, embedded whitespace or a quote anywhere but around the value). Please also skip when modprobe -c itself fails, rather than appending both zeros blind. Add fixtures for -- and for the quoted-whitespace case.
2. Please gate fprintd away from /dev/sep-bio until the owner agrees. libfprint-git's drop-in allows /dev/sep-bio rw unconditionally (omacom/omarchy-pkgs pkgbuilds/libfprint-git/fprintd-aurora-touchid.conf:18), and its Apple driver opens the node read-write when fprintd probes for readers (aurora-apple-sep.patch:383). An open is activation (lib/touchid-activate:44-46), so on an M1 with fprintd installed, the enclave gets a Touch ID activation attempt without the owner's record. That includes every M1 owner who set up a USB reader, which entrypoints/enable-fingerprint:50-64 deliberately allows. The read-only options still keep shared state unwritten, but this is the consent boundary the package draws, on a chip where Touch ID isn't qualified. It also makes "Touch ID stays off, since its activation needs the owner's record" (README.md:30) untrue.
The microphone doesn't need the node: it works once the driver has booted the enclave, with nothing opening sep-bio. So the gate costs the fix nothing, and it can live in this package:
- A systemd generator in omarchy-mac writes a
fprintd.service.ddrop-in withInaccessiblePaths=-/dev/sep-biowhenever/etc/omarchy-mac/touchid-onis absent. fprintd's probe then can't open the node, and USB readers are unaffected. touchid-enablerunssystemctl daemon-reloadbefore the fprintd restart it already does, anddisable-fingerprintreloads and restarts fprintd too, so the drop-in follows the record without a reboot.- Owners who already agreed have the record, so they never get the drop-in. No migration is needed, and M2, M3 and the Neo behave as today.
- Tests: the drop-in is generated without the record and not with it, and enable and disable reload.
Please confirm on the M1 that fprintd then lists only the USB reader. A different mechanism is fine if it gives the same result. If the read-only driver turns out not to register /dev/sep-bio at all, an ls /dev/sep-bio from the boot below is enough to drop this point. linux-aurora#180 needs the same gate, and the cleaner long-term fix is for the kernel not to register the node in read-only mode.
Nice to have: modprobe -b would also honour a blacklist apple_sep an owner set to keep the enclave off. The mask stays the documented opt-out.
Before release, unchanged: cold-boot evidence from an installed M1 (CONTRIBUTING.md:54), meaning Scott's checklist plus journalctl -k -b, systemd-analyze blame, critical-chain display-manager.service and now ls -l /dev/sep-bio. The earlier tester reports came before sep-load. A t6000 or t6001 confirmation would still be good to have.
|
Thanks Naeem.
Still needed before release: the fail-closed parse in sep-load (skip on |
The driver's parameters can be set only once, so an /etc/modprobe.d/apple-sep.conf next to omarchy-mac-touchid.conf passes them twice and every load fails with EEXIST; with omacom/linux-aurora#180 loading the driver at boot, that also silences M1-family microphones. touchid-enable now names the file, says to remove it, and changes nothing. The README no longer claims the options file wins by sorting after apple-sep.conf. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
maralcbr
left a comment
There was a problem hiding this comment.
@malik-na re-reviewed at 927febb, and thanks @scottjones for the commit. The README no longer claims omarchy-mac-touchid.conf wins by sorting. touchid-enable now refuses beside an apple-sep.conf, and it does so before it takes the lock or carves, records or loads anything (lib/touchid-enable:84-86). fail() has nothing to undo at that point, and the check also catches a dangling symlink. The test checks all of that, and checks that the owner's file and an earlier record are left alone (touchid-consent-test.sh:514-526).
One thing before merge:
- The fprintd gate isn't in yet. Per Marcelo's comment of 2026-11-14, the generator gate belongs in this PR as fprintd's permanent consent check. There's no generator or
InaccessiblePaths=underomarchy-mac/yet, andfprintd.service.d/50-omarchy-mac-touchid.confonly orders fprintd. SoREADME.md:30("Touch ID stays off, since its activation needs the owner's record") still doesn't hold on an M1 with fprintd installed. Please add:- the generator that blocks
/dev/sep-biofor fprintd while/etc/omarchy-mac/touchid-onis absent - a
daemon-reloadbeforetouchid-enable's fprintd restart (:168) - a reload and an fprintd restart in
disable-fingerprint - tests for each
- the generator that blocks
Should fix:
enable-fingerprintcan still write the options beside anapple-sep.conf. For an owner who agreed before the options file existed,entrypoints/enable-fingerprint:14-40writesomarchy-mac-touchid.confitself and exits at:48without runningtouchid-enable. The new refusal doesn't apply there, so that owner can still end up with the double setting and EEXIST. The new test attouchid-consent-test.sh:524-526only coverstouchid-enable. Could you run the same check under the lock before:33, with the same message, and add anasktest with the record, anapple-sep.confand no options file?
Smaller things:
README.md:29needs qualifying. It says that withapple_sep.xart_writes=0on the command line "nothing is written". Nothing shared is, buttouchid-enabledoesn't check the command line. With the driver already loaded, which is the normal case once omacom/linux-aurora#180 ships,modprobeexits 0 and the agreement and options stay (:171-175). Every later boot's load then fails with EEXIST, so Touch ID never comes up. Please either reword it, or widen the refusal to anyapple_sepwrite setting thatmodprobe -calready lists while our options file doesn't exist yet. If you widen it, please don't reuse the parsing inlib/sep-load:15-23as it is. Parse fail-closed instead: refuse on a failedmodprobe -cor on any token that isn't a plainname=value.- The PR body needs a refresh:
- add the new refusal to the behaviour notes
- update the version (0.2.7, not 0.2.5)
- drop "so nothing opens it" for
/dev/sep-biountil the gate is in
CI: every listed check passes, including the package suite. The list doesn't name a commit, though, so it's worth confirming the runs are at 927febb. modprobe is stubbed in the suites, so kmod's real behaviour is only covered by a hardware boot.
For release, not the merge (per Marcelo's comment of 2026-11-14):
- The fail-closed parse in
sep-loadis still open.:15-23drops--, splits quoted values on whitespace, and treats a failedmodprobe -cas nothing set (:23). So on a kernel before omacom/linux-aurora#180, the load at:56can go ahead without the read-only options taking effect. Please skip the load in each of those cases, with the microphone message, and add fixtures for--, quoted whitespace and a failingmodprobe -c. - This is boot-critical, so it needs cold-boot evidence from an installed M1 (
CONTRIBUTING.md:54): Scott's checklist plusjournalctl -k -b,systemd-analyze blame,critical-chain display-manager.serviceandls -l /dev/sep-bio, showing fprintd doesn't open it. A t6000 or t6001 confirmation too. - Order, as Marcelo set it: this PR, then omacom/linux-aurora#180, then the kernel pin, then removing
sep-load.
Also:
omarchy-mac/entrypoints/enable-fingerprint:33: This branch writes the options for an owner who already agreed without the newapple-sep.confcheck fromtouchid-enable:84, so the EEXIST case can still happen here. Could it run the same check under this lock first?
Reviewed at 927febbb9df8.
— Marcelo's agent
What
On M1, M1 Pro and M1 Max Macs the built-in microphones sit on the Secure Enclave's data path. Until the enclave boots, every capture is ~40 ms of filter transient followed by exact zeros, and dictation reports "No speech detected". The installed
linux-aurora 7.2.11.aurora14-1builds the driver as a module (CONFIG_APPLE_SEP=m) and the J313 device tree enablessep@242400000, but the module exports no alias, so nothing loads it on a normal boot (omacom/linux-aurora#141, fixed by the unmerged omacom/linux-aurora#180). The package'somarchy-mac-touchid-load.serviceonly runs on the owner's Touch ID record, andtouchid-eligibilityreportsunsupported:m1-familyon these Macs, so that path is closed to them.This adds
omarchy-mac-sep-load.service, which boots the enclave read-only at every boot on the M1 family:omarchy-mac/vendor/systemd/system/omarchy-mac-sep-load.service: oneshot afterlocal-fs.targetand the Touch ID status, beforedisplay-manager.service; skipped while/etc/omarchy-mac/touchid-onexists, since the Touch ID load owns the driver and its options then; waits for/dev/disk/by-partlabel/iBootSystemContainerwithudevadm wait --timeout=20the way the Touch ID load does (the driver opens it as it probes and does not retry); runsmodprobe apple-sep xart_writes=0 provision_keybag=0.omarchy-mac/vendor/systemd/system/multi-user.target.wants/omarchy-mac-sep-load.service: the wants link that pulls it in, as the Touch ID units are.omarchy-mac/lib/sep-for-microphone: the unit'sExecCondition. Reads only the device tree: exit 0 on anapple,t8103,apple,t6000orapple,t6001root whosesoc/sep@*node hascompatibleapple,sepand is enabled; 1 anywhere else, so later Macs and a tree that disables the node never load it.omarchy-mac/test/sep-microphone-test.sh: stages the package, checks the unit's lines (read-only options, the Touch ID condition, the link wait, no device dependency, the ordering), runs the helper against fixture trees (each M1 board with the node enabled, without a status and disabled; M2, M2 Pro and M3 Air boards; no node; another platform; no tree), and runssystemd-analyze verify --rootandsystemd-analyze condition.omarchy-mac/README.md: documents the unit; version0.2.4→0.2.5withomarchy-mac/version.mac-manual/content/12-hardware.md,mac-manual/content/04-security.md: one sentence each on the read-only boot.Never
xart_writes=1orprovision_keybag=1: linux-aurora'stools/aurora-sep/XART-SAFETY.md(on #180) states thatxart_writes=0 provision_keybag=0is read-only operation: the enclave boots, Touch ID stays off, and the xART store shared with macOS is never written. The read-only driver leaves Linux-only state in/var/lib/aurora-sep-host-state.binand exposes/dev/sep-bio;omarchy-mac-touchid-activate.serviceis conditioned on the owner's record, so nothing opens it. Once #180 ships, the module autoloads read-only on its own and this unit becomes a no-op; it can go then.Evidence
Diagnosed and confirmed on a MacBook Air M1 (J313,
apple,t8103, macOS 13.5 firmware) on 2026-11-04:modinfo apple-seplists noalias:line;/proc/device-tree/soc/sep@242400000readscompatible = "apple,sep",status = "okay".sudo modprobe apple-sep xart_writes=0 provision_keybag=0loggedxART ... writes disabled,TZ0 accepted,IMG4 acknowledged, 7 endpoints; the microphone immediately delivered live audio at about -42 dBFS and Superwhisper transcribed speech correctly.Verified
omarchy-mac/test/all: 119 checks pass, including the new test.systemd-analyze verify --rooton the staged unit (systemd 262): clean.bash -non the helper and the test;.github/scripts/check-scopeandcheck-architecture-gatespass.lib/sep-for-microphoneexits 0 on the J313 above.Not verified
/etcor/usron the test Mac; the driver was loaded by hand with the same options.apple,t8103. M1 Pro and M1 Max (t6000,t6001) are gated the same way; the helper also requires their tree to enable the SEP node.markdownmodule); CI builds it.🤖 Generated with Claude Code