Repository navigation
Conversation
BCM4388 (14e4:4434) wedges on real lid-close suspend just like the other parts. The single s2idle test that excluded it did not reproduce the real-world path. Covers omacom#10857.
scottjones
left a comment
There was a problem hiding this comment.
The BCM4388 addition is worth taking. omacom#10857 records a real M2 Pro lid-close failure followed by recovery with the existing service. My earlier healthy M2 Max suspend sample was too narrow to justify excluding the whole chip family.
One blocker before merge: this changes an already-published migration rather than adding a new one.
migrations/1787753224.sh previously exited successfully on BCM4388, so omarchy-migrate marked it complete. The runner checks the filename's completion marker, not whether the script has changed. Existing users who processed that migration will therefore never reach the expanded hardware gate. Fresh provisioning also stamps the existing migrations.
I reproduced this with the actual migration runner in an isolated fixture:
- Run the previous migration against stubbed aarch64/BCM4388 hardware: it skips the hardware and creates its completion marker.
- Replace the migration with this PR's version.
omarchy-migrate --pendingreports nothing pending; a normal run skips the repair, leaving the service absent.
Please add a new timestamped, idempotent migration that invokes the updated hardware leaf for affected installations. Add a runner-level regression with the old migration already marked complete and the recovery service absent. The current tests execute the migration directly, so they cannot catch this upgrade path.
Validation at 19b66f9d: all 21 focused Wi-Fi checks passed, and independently reverting either the leaf gate or migration gate made the suite fail. Command metadata and shebang-aware syntax checks passed; all four hosted checks are green. The local full suite had three environment-related failures: launch-about passed without inherited NO_COLOR, plugin-add passed with fixture Git signing disabled, and settings-package-units remained blocked by a local recipe checkout differing from the pinned revision.
One existing limitation, separate from the migration blocker: the helper also reloads after 12 seconds disconnected without a wedge signature, so it is not strictly a no-op on every unaffected machine. Keep the explicit chip allowlist; slow or out-of-range reconnection remains a useful hardware follow-up.
For the upstream distillation, I would carry this chip addition into the add-on's shared wifi-supported predicate and its tests, preserving its service-mask and administrator-override handling.
Review assisted by Codex. No new hardware suspend/recovery validation was performed for this review.
…d one omarchy-migrate stamps completion per migration filename, so editing the already-published 1787753224.sh could never reach machines that ran it: their marker makes the runner skip the file forever. Restore that file to its published form and ship the BCM4388 gate as a follow-up migration (1790008000.sh) with a narrow 14e4:4434 gate and the same idempotence checks. Adds the runner-level regression from the omacom#465 review: with the published migration marked complete and the recovery service absent, the actual omarchy-migrate still schedules and runs the follow-up, and a completed upgrade path never re-escalates.
|
Fixed in 0d68c9c — you're right, and thanks for catching the marker semantics before this shipped.
All 27 assertions in |
|
Re-review request — the blocker you found is fixed at You asked for a new timestamped, idempotent migration calling the updated hardware leaf instead of an edit to the already-published
Your point that the existing tests execute the migration directly, so they cannot catch the upgrade path, is exactly why that case is written against the runner rather than the script. Verified on my side: 27/27 in that file pass, and all four hosted checks are green. PR is On the two notes you kept separate: I left the 12-second reload alone deliberately, keeping the explicit chip allowlist and treating slow/out-of-range reconnection as its own follow-up as you suggested. And carrying the chip addition into the add-on's shared |
Summary
BCM4388 (
14e4:4434) wedges on real lid-close suspend just like BCM4378/BCM4387 — scans fail and every association is rejected until the driver reloads. Adds4434to the installer leaf gate and the existing-install migration, which was deliberately excluding it based on a single six-minute s2idle test on an M2 Max (PR #255 review) that did not reproduce the real-world lid-close path.The recovery command itself is unchanged: it stays a no-op on machines where the firmware does not wedge (wedge signature + backstop + radio-disabled guard).
Test plan
test/shell.d/wifi-resume-fix-test.sh: BCM4388 on aarch64 now asserts service install + enable; x86_64 with 4434 still skipped; migration installs for aarch64/4434. All 21 assertions pass.bash -nclean on leaf, migration, command, and test.Relates to omacom#10857.