Skip to content

Create Brave's Widevine link through as_root - #565

Merged
maralcbr merged 1 commit into
quattro-upstreamfrom
mac/63-brave-widevine
Sep 26, 2026
Merged

maralcbr merged 1 commit into
quattro-upstreamfrom
mac/63-brave-widevine

Conversation

@maralcbr

Copy link
Copy Markdown
Member

Ticket 63 follow-up to #531. Preparing the Widevine fix for omacom/omarchy, the second review asked for the link to go through as_root like the rest of omarchy-install-browser (runs directly as root, through sudo otherwise) instead of raw sudo. The upstream PR carries the same commit, so this keeps quattro-upstream identical to it and a later sync merges cleanly. The migration keeps sudo, like the other migrations.

The commit also corrects #531's reasoning: x86 installs are unchanged because they don't have the widevine package, not because Brave fetches its own CDM.

Tests: brave-widevine-test.sh (its policy-helper stub now defines as_root through the logging sudo stub) and bin-style-test.sh pass as non-root in an x86_64 Arch container; the Widevine test also passes as root there without touching /opt or /etc.

Second review: no findings on this change; it confirmed the test fails if as_root isn't in scope.

omarchy-install-browser does its other privileged writes through as_root,
which runs the command directly as root and through sudo otherwise. Use it
for the Widevine link too.

The previous commit says x86 installs are unchanged because Brave fetches
its own CDM. The reason is that they don't have the widevine package: an
x86 machine that has it gets the link as well, which Brave handles the same
way.
@maralcbr
maralcbr merged commit 4eabe69 into quattro-upstream Sep 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant