Repository navigation
Create Brave's Widevine link through as_root - #565
Merged
Merged
Conversation
omarchy-install-browser does its other privileged writes through as_root, which runs the command directly as root and through sudo otherwise. Use it for the Widevine link too. The previous commit says x86 installs are unchanged because Brave fetches its own CDM. The reason is that they don't have the widevine package: an x86 machine that has it gets the link as well, which Brave handles the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket 63 follow-up to #531. Preparing the Widevine fix for omacom/omarchy, the second review asked for the link to go through
as_rootlike the rest ofomarchy-install-browser(runs directly as root, through sudo otherwise) instead of rawsudo. The upstream PR carries the same commit, so this keeps quattro-upstream identical to it and a later sync merges cleanly. The migration keepssudo, like the other migrations.The commit also corrects #531's reasoning: x86 installs are unchanged because they don't have the
widevinepackage, not because Brave fetches its own CDM.Tests:
brave-widevine-test.sh(its policy-helper stub now definesas_rootthrough the logging sudo stub) andbin-style-test.shpass as non-root in an x86_64 Arch container; the Widevine test also passes as root there without touching/optor/etc.Second review: no findings on this change; it confirmed the test fails if
as_rootisn't in scope.