Skip to content

Join a self-hosted Tailscale coordination server - #662

Open
z23 wants to merge 2 commits into
omacom:quattrofrom
z23:fix/mac-tailscale-login-server
Open

z23 wants to merge 2 commits into
omacom:quattrofrom
z23:fix/mac-tailscale-login-server

Conversation

@z23

@z23 z23 commented Sep 28, 2026 •

Copy link
Copy Markdown

Fixes #484.

Allow the Tailscale installer to join a self-hosted coordination server such as Headscale and optionally install its admin web app. Hosted Tailscale remains the default.

  • OMARCHY_TAILSCALE_LOGIN_SERVER selects an http(s) coordination-server URL.
  • OMARCHY_TAILSCALE_AUTH_KEY supplies a pre-auth key through --auth-key=file:/dev/stdin, keeping the key out of command arguments. The exported variable is removed before launching child processes.
  • OMARCHY_TAILSCALE_ADMIN_URL selects an optional admin console, including an override for hosted Tailscale.
  • Malformed URLs and whitespace-containing keys fail before installation. Package, daemon and join failures stop subsequent setup.
  • Every join sets --operator to the invoking user, including retries.
  • After a successful self-hosted join without an admin URL, remove only the recognized hosted-console desktop launcher. Preserve custom launchers and shared icons.

The installer matches the reviewed upstream implementation in omacom/omarchy#13533 at 33ff5ea. The networking manual covers command-line settings, menu environment and switching servers.

Validation: 17 stubbed installer scenario groups, Tailscale model and receive tests, command metadata and shebang-aware syntax checks pass. Independent QA and source review found no material issues. ./test/all passes the CLI suite and 291/297 shell test files; the six failures also reproduce on the previous PR head and concern the absent sibling package checkout, inherited NO_COLOR, or the local Python/PyYAML environment. No real tailnet join was performed.

OMARCHY_TAILSCALE_LOGIN_SERVER is passed to tailscale up, and the hosted admin web app is skipped unless OMARCHY_TAILSCALE_ADMIN_URL is set. An optional auth key joins without a browser login. Unset variables keep the hosted install.
@z23
z23 requested review from dhh and ryanrhughes as code owners September 28, 2026 11:18
@z23

z23 commented Oct 2, 2026

Copy link
Copy Markdown
Author

Updated this branch in 448eec0 with the fixes reviewed in omacom/omarchy#13533. The installer now matches that implementation: the operator is supplied on every join, keys travel through stdin, setup stops after a failed join, and successful self-hosted installs remove only the recognized hosted-console launcher. The manual and regression tests are updated too.

The 17 installer scenario groups and related Tailscale tests pass. Independent QA and source review found no material issues. The aggregate run's six shell-test failures reproduce on the previous head and are package-checkout or local test-environment issues; the CLI suite and other 291 shell files pass. I have not performed a real tailnet join on Mac hardware.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

omarchy-install-service-tailscale hangs on self-hosted control servers (no --login-server)

1 participant