Repository navigation
Accept aarch64-apple as the Mac platform in omarchy-mac-migrate - #726
Open
patrikduksin wants to merge 1 commit into
Open
patrikduksin wants to merge 1 commit into
patrikduksin wants to merge 1 commit into
Conversation
omacom/omarchy omacom#14431 renamed the detector's Apple Silicon platform to aarch64-apple. A migrated Mac runs that detector, so a boot that retries pending user setup after the migration completed read the Mac as another platform and returned without retrying. Accept both names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
This was referenced Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #690.
omacom#14431 renamed the detector's Apple Silicon platform from
apple-silicontoaarch64-apple.runandverifystill comparedhardware_platformwithapple-silicon(engine.sh,migrate_runandmigrate_verify).The first run is unaffected, because a fork runtime has no
omarchy-hw-platformand the device-tree fallback saysapple-silicon. Once the migration completes,past_boundaryis false and the migrated runtime's detector saysaarch64-apple. The boot unit then returns without retrying pending user setup, and a rerun ofrunreports "Not an Apple Silicon Mac". This addsapple_platform, which accepts both names, and uses it in both places.Tests: the user-pending test now switches the fixture platform to
aarch64-applebefore the boot that retries, as on a migrated Mac. It fails without the change and passes with it.mac-migrate-test(49),mac-migrate-mx-test(28) andmac-move-migration-test(4) pass, andmigrate/build --checkis clean.bin/omarchy-mac-migrateand the README checksum are rebuilt. Inmac-migrate-legacy-test, "the root's /boot gets the converged systemd image" fails on this machine both with and without this change, so it is environment-dependent and not caused by this fix. shellcheck was not available locally.Related, not in this PR: upstream migration 1791581004 fails on Apple Silicon (omacom#15223, fix in omacom#15279). A Mac migrated today keeps hitting it on every
omarchy updateuntil that fix lands, because it is not among the migrationssettled_migrationsmarks.🤖 Generated with Claude Code