Skip to content

Use the command helper in the AI app removers - #10460

Merged
spencerbull merged 1 commit into
omacom:quattrofrom
codemonkey76:fix-openclaw-cmd-present
Sep 7, 2026
Merged

Use the command helper in the AI app removers#10460
spencerbull merged 1 commit into
omacom:quattrofrom
codemonkey76:fix-openclaw-cmd-present

Conversation

@codemonkey76

Copy link
Copy Markdown
Contributor

test/shell.d/bin-style-test.sh currently fails on quattro. The OpenClaw remover checks for gum with a raw command -v, which the style rule reserves for the helpers themselves:

$ ./test/all
bin/omarchy-remove-ai-openclaw
not ok - bin commands use command helpers

The Hermes remover does the same thing. That one is invisible until the first is fixed, because the test reports only the first offending file — so fixing OpenClaw alone just moves the failure along to the next.

Both now use omarchy-cmd-present, matching the rest of bin/.

Test plan

  • ./test/all226/226 files pass. Before this change, bin-style-test.sh failed and the suite reported 1 of 226 failing.
  • rg -l 'command -v' bin/ | rg -v '/omarchy-(cmd-|pkg-|upgrade-to-quattro)' returns nothing.

🤖 Generated with Claude Code

https://claude.ai/code/session_013p9Qh6dX4FuwBJAWhNPVbn

test/shell.d/bin-style-test.sh has been failing on quattro: the OpenClaw
remover checks for gum with a raw `command -v`, which the style rule
reserves for the helpers themselves.

The Hermes remover does the same thing. It was invisible because the test
fails on the first offending file, so fixing OpenClaw alone just moves the
failure along.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013p9Qh6dX4FuwBJAWhNPVbn

@smfworks smfworks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Approved

Replacing raw command -v gum with omarchy-cmd-present gum in both AI removers matches the bin-style rule and unblocks ./test/all on quattro. Hermes and OpenClaw keep the same keep-data-by-default prompt.

Note: #10443 also touches bin/omarchy-remove-ai-hermes (it drops the gum presence check entirely). Merge this first so OpenClaw is fixed; rebase #10443 so the Hermes remover does not reintroduce command -v.

@spencerbull
spencerbull merged commit 18410a0 into omacom:quattro Sep 7, 2026
ryanrhughes pushed a commit that referenced this pull request Sep 8, 2026
Use the command helper in the AI app removers

(cherry picked from commit 18410a0)
(cherry picked from commit 67125c330b36204356a92867b9c9120a4599afae)
ryanrhughes pushed a commit that referenced this pull request Sep 8, 2026
Use the command helper in the AI app removers

(cherry picked from commit 18410a0)
(cherry picked from commit 67125c330b36204356a92867b9c9120a4599afae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants