Use the command helper in the AI app removers - #10460
Merged
Merged
Conversation
test/shell.d/bin-style-test.sh has been failing on quattro: the OpenClaw remover checks for gum with a raw `command -v`, which the style rule reserves for the helpers themselves. The Hermes remover does the same thing. It was invisible because the test fails on the first offending file, so fixing OpenClaw alone just moves the failure along. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013p9Qh6dX4FuwBJAWhNPVbn
4 tasks
smfworks
approved these changes
Sep 6, 2026
smfworks
left a comment
Contributor
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Replacing raw command -v gum with omarchy-cmd-present gum in both AI removers matches the bin-style rule and unblocks ./test/all on quattro. Hermes and OpenClaw keep the same keep-data-by-default prompt.
Note: #10443 also touches bin/omarchy-remove-ai-hermes (it drops the gum presence check entirely). Merge this first so OpenClaw is fixed; rebase #10443 so the Hermes remover does not reintroduce command -v.
5 tasks
spencerbull
approved these changes
Sep 7, 2026
spencerbull
approved these changes
Sep 7, 2026
ryanrhughes
pushed a commit
that referenced
this pull request
Sep 8, 2026
Use the command helper in the AI app removers (cherry picked from commit 18410a0) (cherry picked from commit 67125c330b36204356a92867b9c9120a4599afae)
ryanrhughes
pushed a commit
that referenced
this pull request
Sep 8, 2026
Use the command helper in the AI app removers (cherry picked from commit 18410a0) (cherry picked from commit 67125c330b36204356a92867b9c9120a4599afae)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/shell.d/bin-style-test.shcurrently fails onquattro. The OpenClaw remover checks forgumwith a rawcommand -v, which the style rule reserves for the helpers themselves:The Hermes remover does the same thing. That one is invisible until the first is fixed, because the test reports only the first offending file — so fixing OpenClaw alone just moves the failure along to the next.
Both now use
omarchy-cmd-present, matching the rest ofbin/.Test plan
./test/all— 226/226 files pass. Before this change,bin-style-test.shfailed and the suite reported 1 of 226 failing.rg -l 'command -v' bin/ | rg -v '/omarchy-(cmd-|pkg-|upgrade-to-quattro)'returns nothing.🤖 Generated with Claude Code
https://claude.ai/code/session_013p9Qh6dX4FuwBJAWhNPVbn