Repository navigation
Cap the screensaver frame rate and make it configurable - #10467
Closed
Eric-Fernald wants to merge 1 commit into
Closed
Eric-Fernald wants to merge 1 commit into
Eric-Fernald wants to merge 1 commit into
Conversation
omarchy-screensaver hardcoded --frame-rate 120 for ttfx. The screensaver terminal (foot by default) rasterizes every frame on the CPU at native panel resolution, so on HiDPI displays that pinned several cores and thermally throttled the machine; on QXL VMs it exhausted video memory. Most of those frames were wasted anyway, since the panels refresh at 60Hz. Default to 60fps and cap each screensaver window to its monitor's refresh rate: omarchy-launch-screensaver passes the rate from hyprctl monitors as OMARCHY_SCREENSAVER_MAX_FRAME_RATE, and the new omarchy-screensaver-frame-rate helper resolves it against idle.screensaverFrameRate in shell.json, so the rate can be lowered further without editing package-owned files. Fixes omacom#9193 Fixes omacom#8554
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
omarchy-screensaverhardcoded--frame-rate 120for ttfx. The screensaver terminal (foot by default) rasterizes every frame on the CPU at native panel resolution, so on HiDPI displays that pinned several cores and thermally throttled the machine. On QXL VMs it exhausted video memory.Most of those frames were wasted anyway, since the panels refresh at 60Hz.
Fix
omarchy-launch-screensaverreads the rate fromhyprctl monitorsand passes it asOMARCHY_SCREENSAVER_MAX_FRAME_RATE.omarchy-screensaver-frame-ratehelper resolvesidle.screensaverFrameRatefromshell.json, so the rate can be lowered further without editing package-owned files.Testing
test/shell.d/screensaver-frame-rate-test.shcovers the default, config reads, invalid values, broken JSON, refresh-rate capping, and the wiring through both scripts.omarchy commands --checkpasses with the new hidden helper registered.Relationship to PR #8556
#8556 makes the frame rate overridable via OMARCHY_SCREENSAVER_FRAME_RATE but keeps 120 as the default, so affected machines still hit the problem until the user finds the variable. This PR changes the default: 60fps capped to the monitor's real refresh rate, since ttfx frames above that are discarded by the compositor. That fixes #9193 and #8554 for everyone without configuration, and puts the override in shell.json alongside the other idle settings rather than in UWSM env. Happy to add the env var as an additional override if that's preferred.
Fixes #9193
Fixes #8554