Repository navigation
Dismiss screensaver on bare Ctrl while it is open - #10587
fresh3nough wants to merge 1 commit into
Conversation
|
Heads up on ReproductionIsolated it with standalone debug binds, unrelated to the screensaver entirely: o.bind("Control_L", "debug", "notify-send ctrl-release", { release = true }) -- never fires
o.bind("Super_L", "debug", "notify-send super-release", { release = true }) -- never fires
o.bind("Control_L", "debug", "notify-send ctrl-press", {}) -- fires immediately
What worked insteadPress-triggered with o.bind("Control_L", "Wake screensaver (tap Ctrl)", cmd, { non_consuming = true })
o.bind("Control_R", "Wake screensaver (tap Ctrl)", cmd, { non_consuming = true })Extended the same pattern to Not sure if this is Hyprland-version-specific (worth checking on whatever version CI/reviewers are testing against) or a broader regression, but wanted to flag it in case |
omarchy-screensaver only exits on a tty byte (read -n1) or signals. Bare Ctrl never delivers a byte, and idle's handleActiveSignal swallows compositor activity while the screensaver window is up, so a lone Ctrl tap did nothing (issue #10583). While an org.omarchy.screensaver window is open, bind Control_L/R on press with non_consuming=true to SIGHUP the screensaver process (same trap exit_screensaver already handles). Bare-modifier binds with release=true register but never dispatch on Hyprland 0.56.2; press + non_consuming does. No global mouse wake — that path was removed in v3.3.0 for Bluetooth mice. Fixes #10583 Signed-off-by: fresh3nough <anonwurcod@proton.me>
|
Thanks for the detailed report — confirmed on Hyprland 0.56.2 ( Switched the screensaver wake binds to press +
|
01e10e4 to
f124fb4
Compare
|
Reviewed at f124fb4 against The bug is real. Competing fix: #7528. It arms a second On this pull request as it stands, three things a maintainer would need to know if it went ahead anyway:
There is one more overlap: #6813 reworks screensaver teardown so it no longer uses Second opinion: Codex Medium, which reviewed all three pull requests, read-only. Its choice of #7528 matches mine. Its independence from my reasoning is not guaranteed. On its own it added the point about Ctrl combinations, and it traced the bare-Ctrl coverage to Hyprland's input manager calling idle-notify for modifier changes. This is now waiting on the maintainer to choose between #7528 and this pull request. Nothing is needed from you unless they ask. |
Summary
Fixes #10583 (Ctrl-tap half only).
omarchy-screensaverexits on tty bytes (read -n1) or signals. Bare Ctrl is a modifier with no tty byte, so it never wakes the screensaver. Separately, idle'shandleActiveSignal()intentionally ignores compositor activity while the screensaver window exists (to avoid self-close on launch).v3.3.0 removed global mouse-to-wake for Bluetooth mice. This PR does not restore mouse wake.
Change
While an
org.omarchy.screensaverwindow is open (tracked viawindow.open/close/destroy, same pattern as selection-layer binds):Control_L/Control_Rwithnon_consuming = trueandlocked = truepkill -HUP -f '[o]rg.omarchy.screensaver'(hits the existingexit_screensaverSIGHUP trap)Uses press +
non_consuming, notrelease = true: on Hyprland 0.56.2 bare-modifier release binds register but never dispatch (reproduced standalone; see review discussion).Evidence
Bug reproduced
Ctrl alone → no tty byte → no wake. Activity signal swallowed while window up.
Fix validated
Test plan
omarchy-launch-screensaver force→ tap Ctrl alone → dismisses