Repository navigation
Fix emoji picker paste for Firefox and mouse selection - #10591
fresh3nough wants to merge 1 commit into
Conversation
|
#8573 fixes the emoji picker for both Firefox and mouse usage. This one doesn't address the latter. |
omarchy-menu-emoji-insert used a clipboard offer plus synthetic Shift+Insert. That fails in two ways: - Firefox-based browsers map Shift+Insert to PRIMARY, so a clipboard-only offer pastes nothing (issue #10382). - Chromium/Electron ignore wtype Unicode; terminals need typing, not paste. - After the fullscreen picker closes, follow_mouse focuses the window under the cursor, so mouse-picked emojis land in the wrong window. Capture the origin window address in Emojis.qml, re-focus it before insert, type into terminals, and paste with transient clipboard + Ctrl+V elsewhere. Fixes #10382 Signed-off-by: fresh3nough <anonwurcod@proton.me>
|
Thanks for the pointer. You are right that the first revision only covered the Firefox PRIMARY/Shift+Insert mismatch and left the mouse origin-window case alone. Updated this PR to cover both:
Happy to close this in favor of #8573 if that lands first; otherwise this is the same shape of fix on current |
fa9300d to
b440327
Compare
|
This is now a line for line duplicate of #8573 . I don't know what you are trying to achieve with this. Either way it's a weird new variant of plagiarism. Why not put your energy in fixing new problems, instead of duplicating existing PRs? Strange. |
Summary
Fixes #10382.
omarchy-menu-emoji-insertused a transient clipboard offer plus syntheticShift+Insert. That breaks in several ways:Shift+Insertto PRIMARY, so a clipboard-only offer pastes nothing (manual Ctrl+V worked).wtypeuses for Unicode, so typing an emoji never arrives — they need a real clipboard paste.follow_mousefocuses whatever window is under the (centred) cursor, so a mouse-picked emoji often lands in the wrong window.Change
Emojis.qmlcapturesHyprland.activeToplevel.addressinopen()(with a last-known fallback) and passes it to the insert helper.omarchy-menu-emoji-insert:[window-address]argument; normalises bare hex, re-focuses viahl.dsp.focus(classicfocuswindowfallback), polls until active;terminaltag →wtypethe emoji (clipboard untouched);Ctrl+V, then withdraw.Related: #8573 takes the same overall approach and is acknowledged in review; this PR brings that shape onto current
quattrofor #10382.Evidence
Test plan